[Pkg-javascript-devel] Bug#977792: closed by Debian FTP Masters

[Jérémy Lal]

Le dim. 29 mai 2022 à 19:18, Kevin Locke <kevin at kevinlocke.name> a écrit :

> found 977792 16.15.0+dfsg-1
> thanks
>
> On Fri, 2022-05-27 at 14:54 +0000, Debian Bug Tracking System wrote:
> > This is an automatic notification regarding your Bug report
> > which was filed against the nodejs package:
> >
> > #977792: nodejs: install bash-completion script
> >
> > It has been closed by Debian FTP Masters <
> ftpmaster at ftp-master.debian.org> (reply to Jérémy Lal <kapouer at melix.org
> >).
>
> Thanks for working on this issue!  Unfortunately, it does not appear
> to be fixed in 16.15.0+dfsg-1, as the
> /usr/share/bash-completion/completions directory is empty in this
> version:
>
>     $ dget nodejs=16.15.0+dfsg-1
>     $ dpkg -c nodejs_16.15.0+dfsg-1_amd64.deb | grep bash-completion
>     drwxr-xr-x root/root         0 2022-05-27 07:48
> ./usr/share/bash-completion/
>     drwxr-xr-x root/root         0 2022-05-27 07:48
> ./usr/share/bash-completion/completions/
>
> The buildd log for amd64[1] includes:
>
>     /bin/sh: 1: ./node: not found
>
> in debian/rules override_dh_auto_build-arch on line 1443.  Which
> appears be the source of the problem.  Apparently the error is not
> fatal because it occurs in a variable substitution?  Was that
> intentional?  Perhaps it could be fixed and made fatal with:
>
> --- a/debian/rules
> +++ b/debian/rules
> @@ -257,7 +257,7 @@ endif
>
>  override_dh_auto_build-arch: deps_build
>         dh_auto_build
> -       $(shell ./node --completion-bash > ./debian/nodejs.bash-completion)
> +       ./out/Release/node --completion-bash >
> ./debian/nodejs.bash-completion
>
>  override_dh_auto_build-indep: deps_links
>         mkdir -p $(DEBIAN_DOC_DEPS)
>
>
> It may also be worth considering adding nodejs.links with content:
> /usr/share/bash-completion/completions/node
>  /usr/share/bash-completion/completions/nodejs
> So that users will get completion for `node <tab>` in addition to
> `nodejs <tab>`.
>

Well, exactly !
And thank you !
The next update will fix this.

Jérémy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-javascript-devel/attachments/20220529/00e17cf4/attachment.htm>