[Pkg-javascript-devel] Bug#1048048: node-xterm: Fails to build source after successful build

[Lucas Nussbaum]

Source: node-xterm
Version: 3.8.1+~cs0.9.0-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package node-xterm
> dpkg-buildpackage: info: source version 3.8.1+~cs0.9.0-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Pirate Praveen <praveen at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean --with nodejs
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> dh_auto_clean
> rm -rf node_modules lib dist build
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building node-xterm using existing ./node-xterm_3.8.1+~cs0.9.0.orig-node-pty.tar.gz
> dpkg-source: info: building node-xterm using existing ./node-xterm_3.8.1+~cs0.9.0.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: error: cannot represent change to node-pty/node_modules/@types/mocha:
> dpkg-source: error:   new version is symlink to /usr/share/nodejs/@types/mocha
> dpkg-source: error:   old version is nonexistent
> dpkg-source: error: cannot represent change to node-pty/node_modules/@types/node:
> dpkg-source: error:   new version is symlink to /usr/share/nodejs/@types/node
> dpkg-source: error:   old version is nonexistent
> dpkg-source: warning: ignoring deletion of file src/Terminal.integration.ts, use --include-removal to override
> dpkg-source: error: unrepresentable changes to source
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 255
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/node-xterm_3.8.1+~cs0.9.0-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.