[Pkg-javascript-devel] Bug#1048795: node-formidable: Fails to build source after successful build

[Lucas Nussbaum]

Source: node-formidable
Version: 3.2.5+20221017git493ec88+~cs4.0.9-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package node-formidable
> dpkg-buildpackage: info: source version 3.2.5+20221017git493ec88+~cs4.0.9-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Yadd <yadd at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    dh_auto_clean --buildsystem=nodejs
> 	rm -rf ./node_modules/.cache ./.nyc_output
> 	rm -rf dezalgo/node_modules/.cache dezalgo/.nyc_output
> 	rm -rf hexoid/node_modules/.cache hexoid/.nyc_output
> 	rm -rf types-formidable/node_modules/.cache types-formidable/.nyc_output
> rm ./node_modules/.cache
> rm dezalgo/node_modules/.cache
> rm hexoid/node_modules/.cache
> rm types-formidable/node_modules/.cache
> unlink node_modules/dezalgo
> unlink node_modules/hexoid
> unlink node_modules/@types/formidable
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building node-formidable using existing ./node-formidable_3.2.5+20221017git493ec88+~cs4.0.9.orig-dezalgo.tar.xz
> dpkg-source: info: building node-formidable using existing ./node-formidable_3.2.5+20221017git493ec88+~cs4.0.9.orig-hexoid.tar.xz
> dpkg-source: info: building node-formidable using existing ./node-formidable_3.2.5+20221017git493ec88+~cs4.0.9.orig-types-formidable.tar.xz
> dpkg-source: info: building node-formidable using existing ./node-formidable_3.2.5+20221017git493ec88+~cs4.0.9.orig.tar.xz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: file node-formidable-3.2.5+20221017git493ec88+~cs4.0.9/hexoid/dist/index.min.js has no final newline (either original or modified version)
> dpkg-source: info: local changes detected, the modified files are:
>  node-formidable-3.2.5+20221017git493ec88+~cs4.0.9/hexoid/dist/index.js
>  node-formidable-3.2.5+20221017git493ec88+~cs4.0.9/hexoid/dist/index.min.js
>  node-formidable-3.2.5+20221017git493ec88+~cs4.0.9/hexoid/dist/index.mjs
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/node-formidable_3.2.5+20221017git493ec88+~cs4.0.9-1.diff.Garci8
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/node-formidable_3.2.5+20221017git493ec88+~cs4.0.9-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.