[Pkg-javascript-devel] Bug#1049548: node-graphql: Fails to build binary packages again after successful build

[Lucas Nussbaum]

Source: node-graphql
Version: 16.6.0-2
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-binary-20230816 ftbfs-binary-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to do build a binary-only build (not source) after a
successful build (dpkg-buildpackage ; dpkg-buildpackage -b).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/DoubleBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -b
> --------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package node-graphql
> dpkg-buildpackage: info: source version 16.6.0-2
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Yadd <yadd at debian.org>
>  dpkg-source --before-build .
> dpkg-buildpackage: info: host architecture amd64
>  debian/rules clean
> dh clean
>    dh_auto_clean --buildsystem=nodejs
> 	rm -rf npmDist/node_modules/.cache npmDist/.nyc_output
> rm npmDist/node_modules/.cache
>    dh_clean
>  debian/rules binary
> dh binary
>    dh_update_autotools_config
>    dh_autoreconf
>    dh_auto_configure --buildsystem=nodejs
> Unable to link /usr/share/nodejs/@types/chai into ./node_modules/@types/chai: dest exists
> Unable to link /usr/share/nodejs/@types/mocha into ./node_modules/@types/mocha: dest exists
> Unable to link /usr/share/nodejs/@types/node into ./node_modules/@types/node: dest exists
>    dh_auto_build --buildsystem=nodejs
> Found debian/nodejs/./build
> 	cd ./. && sh -ex debian/nodejs/./build
> + node resources/build-npm.js
> node:internal/fs/utils:348
>     throw err;
>     ^
> 
> Error: EEXIST: file already exists, mkdir './npmDist'
>     at Object.mkdirSync (node:fs:1395:3)
>     at Object.<anonymous> (/<<PKGBUILDDIR>>/resources/build-npm.js:18:6)
>     at Module._compile (node:internal/modules/cjs/loader:1218:14)
>     at Module._extensions..js (node:internal/modules/cjs/loader:1272:10)
>     at Module.load (node:internal/modules/cjs/loader:1081:32)
>     at Module._load (node:internal/modules/cjs/loader:922:12)
>     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
>     at node:internal/main/run_main_module:23:47 {
>   errno: -17,
>   syscall: 'mkdir',
>   code: 'EEXIST',
>   path: './npmDist'
> }
> 
> Node.js v18.13.0
> dh_auto_build: error: cd ./. && sh -ex debian/nodejs/./build returned exit code 1
> make: *** [debian/rules:8: binary] Error 25
> dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -b' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/16/node-graphql_16.6.0-2_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.