[Pkg-javascript-devel] Bug#1049844: node-xterm: Fails to build binary packages again after successful build

[Lucas Nussbaum]

Source: node-xterm
Version: 3.8.1+~cs0.9.0-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-binary-20230816 ftbfs-binary-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to do build a binary-only build (not source) after a
successful build (dpkg-buildpackage ; dpkg-buildpackage -b).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/DoubleBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -b
> ------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package node-xterm
> dpkg-buildpackage: info: source version 3.8.1+~cs0.9.0-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Pirate Praveen <praveen at debian.org>
>  dpkg-source --before-build .
> dpkg-buildpackage: info: host architecture amd64
>  debian/rules clean
> dh clean --with nodejs
>    debian/rules override_dh_auto_clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> dh_auto_clean
> rm -rf node_modules lib dist build
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_clean
>  debian/rules binary
> dh binary --with nodejs
>    dh_update_autotools_config
>    dh_autoreconf
>    dh_auto_configure --buildsystem=nodejs
> Link ./node_modules/@types/glob -> /usr/share/nodejs/@types/glob
> Link ./node_modules/@types/chai -> /usr/share/nodejs/@types/chai
> Link ./node_modules/@types/jquery -> /usr/share/nodejs/@types/jquery
> Link ./node_modules/@types/jsdom -> /usr/share/nodejs/@types/jsdom
> Link ./node_modules/@types/mocha -> /usr/share/nodejs/@types/mocha
> Link ./node_modules/@types/node -> /usr/share/nodejs/@types/node
> Unable to link /usr/share/nodejs/@types/mocha into node-pty/node_modules/@types/mocha: dest exists
> Unable to link /usr/share/nodejs/@types/node into node-pty/node_modules/@types/node: dest exists
> Link node_modules/node-pty -> ../node-pty
>    debian/rules override_dh_auto_build
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> # requires node-pty bindings, embedded but build fails
> rm src/Terminal.integration.ts
> rm: cannot remove 'src/Terminal.integration.ts': No such file or directory
> make[1]: *** [debian/rules:14: override_dh_auto_build] Error 1
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
> make: *** [debian/rules:10: binary] Error 2
> dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -b' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/16/node-xterm_3.8.1+~cs0.9.0-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.