[Pkg-javascript-devel] Bug#1057707: Bug#1057707: eslint is incompatible with node-ajv >= 8

[Yadd]

On 12/8/23 03:59, Jonas Smedegaard wrote:
> Quoting Yadd (2023-12-07 14:37:31)
>> Control: tags -1 + patch
>>
>> On 12/7/23 15:52, Jérémy Lal wrote:
>>>
>>>
>>> Le jeu. 7 déc. 2023 à 12:45, Yadd <yadd at debian.org
>>> <mailto:yadd at debian.org>> a écrit :
>>>
>>>      Package: eslint
>>>      Version: 6.4.0~dfsg+~6.1.9-7
>>>      Severity: important
>>>      Tags: ftbfs upstream
>>>
>>>      Hi,
>>>
>>>      eslint depends on node-ajv 6 and is incompatible with node-ajv 8
>>>      (available in exeprimental branch). All is in lib/shared/ajv.js:
>>>
>>>        - eslint requires 'ajv/lib/refs/json-schema-draft-04.json' which is no
>>>          more available
>>>        - eslint tries to set `ajv._opts.defaultMeta` which is
>>>          `ajv.opts.defaultMeta` in node-ajv 8.
>>>
>>>      Changing "ajv/lib/refs/json-schema-draft-04.json" to
>>>      "ajv/lib/refs/json-schema-draft-06.json" doesn't work. I tried this
>>>      patch which looks to work but 27 tests fail (not the good error string).
>>>      It uses default ajv schemas.
>>>
>>>      Help needed here ;-)
>>>
>>>
>>> I suppose you tried
>>> https://github.com/eslint/eslint/pull/13911/commits
>>> <https://github.com/eslint/eslint/pull/13911/commits>
>>> ?
>>
>> Thanks a lot Jérémy! Based on your suggestion, I succeed to build a patch.
>>
>> @Jonas, do you agree if I push this to experimental ?
> 
> If it succeeds the testsuite then by all means, go for it.

Hi,

sure, all test passed now. Only error strings had to be updated

Cheers,
Yadd