[Pkg-javascript-devel] Bug#1064251: nodejs: NMU diff for 64-bit time_t transition

[Steve Langasek]

Source: nodejs
Version: 18.19.0+dfsg-6
Severity: important
Tags: patch pending sid trixie
User: debian-arm at lists.debian.org
Usertags: time-t

NOTICE: these changes must not be uploaded to unstable yet!

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
nodejs as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for nodejs
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-14-generic (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
diff -Nru nodejs-18.19.0+dfsg/debian/changelog nodejs-18.19.0+dfsg/debian/changelog
--- nodejs-18.19.0+dfsg/debian/changelog	2023-12-03 21:41:14.000000000 +0000
+++ nodejs-18.19.0+dfsg/debian/changelog	2024-02-19 00:19:51.000000000 +0000
@@ -1,3 +1,10 @@
+nodejs (18.19.0+dfsg-6.1) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+
+ -- Steve Langasek <vorlon at debian.org>  Mon, 19 Feb 2024 00:19:51 +0000
+
 nodejs (18.19.0+dfsg-6) unstable; urgency=medium
 
   * patch: remove useless and badly done icu_74 patch
diff -Nru nodejs-18.19.0+dfsg/debian/control nodejs-18.19.0+dfsg/debian/control
--- nodejs-18.19.0+dfsg/debian/control	2023-11-30 08:54:40.000000000 +0000
+++ nodejs-18.19.0+dfsg/debian/control	2024-02-19 00:19:51.000000000 +0000
@@ -55,7 +55,7 @@
 Depends: ${misc:Depends},
  libssl-dev (>= 1.1.1~),
  libuv1-dev (>= 1.33.0~),
- libnode108 (= ${binary:Version})
+ libnode108t64 (= ${binary:Version})
 Breaks: nodejs-dev (<< 10.0.0~dfsg1-3)
 Replaces: libv8-dev,
  nodejs-dev (<< 10.0.0~dfsg1-3)
@@ -68,7 +68,7 @@
  efficient, perfect for data-intensive real-time applications that run
  across distributed devices.
  .
- This package provides development headers for libnode108
+ This package provides development headers for libnode108t64
 
 Package: nodejs
 Architecture: amd64 arm64 armel armhf i386 kfreebsd-i386 kfreebsd-amd64 mips mips64el mips64r6el mipsel powerpc ppc64 ppc64el riscv64 s390x
@@ -78,7 +78,7 @@
  ${misc:Depends},
  sse2-support [i386],
  armv6k-support [armel], vfpv2-support [armel],
- libnode108 (= ${binary:Version})
+ libnode108t64 (= ${binary:Version})
 Recommends: ca-certificates,
  nodejs-doc
 Suggests: npm
@@ -105,7 +105,8 @@
  System, Events, Standard I/O, Modules, Timers, Child Processes, POSIX,
  HTTP, Multipart Parsing, TCP, DNS, Assert, Path, URL, Query Strings.
 
-Package: libnode108
+Package: libnode108t64
+Provides: ${t64:Provides}
 Section: libs
 Architecture: amd64 arm64 armel armhf i386 kfreebsd-i386 kfreebsd-amd64 mips mips64el mips64r6el mipsel powerpc ppc64 ppc64el riscv64 s390x
 Multi-Arch: same
@@ -116,10 +117,10 @@
  node-acorn (>= 6.2.1~) <!pkg.nodejs.nobuiltin>,
  node-cjs-module-lexer (>= 1.2.2~) <!pkg.nodejs.nobuiltin>,
  node-undici (>= 5.0.0~) <!pkg.nodejs.nobuiltin>
-Breaks: node-modern-syslog (<< 1.1.4-2),
+Breaks: libnode108 (<< ${source:Version}), node-modern-syslog (<< 1.1.4-2),
  libnode64 (<< 10.24.1~),
  libnode72 (<< 13)
-Replaces: nodejs-legacy, libnode72, libnode83, libnode93
+Replaces: libnode108, nodejs-legacy, libnode72, libnode83, libnode93
 Conflicts: nodejs-legacy
 Description: evented I/O for V8 javascript - runtime library
  Node.js is a platform built on Chrome's JavaScript runtime for easily
diff -Nru nodejs-18.19.0+dfsg/debian/libnode108.install nodejs-18.19.0+dfsg/debian/libnode108.install
--- nodejs-18.19.0+dfsg/debian/libnode108.install	1970-01-01 00:00:00.000000000 +0000
+++ nodejs-18.19.0+dfsg/debian/libnode108.install	2024-02-19 00:19:51.000000000 +0000
@@ -0,0 +1 @@
+usr/lib/libnode.so.* usr/lib/x86_64-linux-gnu/
diff -Nru nodejs-18.19.0+dfsg/debian/libnode108t64.lintian-overrides nodejs-18.19.0+dfsg/debian/libnode108t64.lintian-overrides
--- nodejs-18.19.0+dfsg/debian/libnode108t64.lintian-overrides	1970-01-01 00:00:00.000000000 +0000
+++ nodejs-18.19.0+dfsg/debian/libnode108t64.lintian-overrides	2024-02-19 00:19:51.000000000 +0000
@@ -0,0 +1 @@
+libnode108t64: package-name-doesnt-match-sonames libnode108
diff -Nru nodejs-18.19.0+dfsg/debian/rules nodejs-18.19.0+dfsg/debian/rules
--- nodejs-18.19.0+dfsg/debian/rules	2023-11-30 15:59:46.000000000 +0000
+++ nodejs-18.19.0+dfsg/debian/rules	2024-02-19 00:19:51.000000000 +0000
@@ -10,7 +10,7 @@
 builtins := /usr/share/nodejs/node
 
 # source equivalent of nodejs -e 'console.log(process.versions.modules)'
-ABI = $(shell awk '/^#define NODE_MODULE_VERSION/ {print $$3}' src/node_version.h)
+ABI = $(shell awk '/^#define NODE_MODULE_VERSION/ {print $$3}' src/node_version.h)t64
 
 # archs
 ARCHS := amd64 arm64 armel armhf i386 kfreebsd-i386 kfreebsd-amd64 mips mips64el mips64r6el mipsel ppc64 ppc64el riscv64 s390x