<div id="geary-body" dir="auto"><div><br></div></div><div id="geary-quote" dir="auto"><br>On Thu, Sep 26, 2019 at 16:44, Pirate Praveen <praveen@onenetbeyond.org> wrote:<br><blockquote type="cite"><div id="geary-body" dir="auto"><div><br></div></div><div id="geary-quote" dir="auto"><br>On Thu, Sep 26, 2019 at 15:57, Pirate Praveen <praveen@onenetbeyond.org> wrote:<br><blockquote type="cite"><div class="plaintext" style="white-space: pre-wrap;">With 0.52.0 in the archive, I think we can jump to 0.56.3 now.</div></blockquote><div style="white-space: pre-wrap;"><span style="white-space: pre-wrap;"><br></span></div><div style="white-space: pre-wrap;"><span style="white-space: pre-wrap;">I have imported 0.56.3 to master-0.56 branch but it is not building. There is one good and one bad news with this update.</span></div><div style="white-space: pre-wrap;"><span style="white-space: pre-wrap;"><br></span></div><div style="white-space: pre-wrap;"><span style="white-space: pre-wrap
;">Good news, they no longer use buble in the build process (it is only used in tests). Bad news, they switched to typescript and node-rollup-plugin is broken, see </span>https://bugs.debian.org/cgi-bin/
bugreport.cgi?bug=933091</div><div><br><blockquote type="cite"><div class="plaintext" style="white-space: pre-wrap;"></div></blockquote></div><div>So we either need to fix that or manually run typescript.</div></div></blockquote><br><div>When manually running tsc, (in master-0.56 branch)</div><div><br></div><div><div>tsc</div><div>src/Graph.ts:92:31 - error TS1345: An expression of type 'void' cannot be tested for truthiness</div><div><br></div><div>92 <span class="Apple-tab-span" style="white-space:pre"> </span>if (plugin.options) return plugin.options(acc) || acc;</div><div> <span class="Apple-tab-span" style="white-space:pre"> </span> ~~~~~~~~~~~~~~~~~~~</div><div><br></div><div>src/ast/ExecutionPathOptions.ts:1:23 - error TS7016: Could not find a declaration file for module 'immutable'. '/usr/share/nodejs/immutable/dist/immutable.js' implicitly has an 'any' type.</div>
<div> Try `npm install @types/immutable` if it exists or add a new declaration (.d.ts) file containing `declare module 'immutable';`</div><div><br></div><div>1 import Immutable from 'immutable';</div><div> ~~~~~~~~~~~</div><div><br></div><div>src/utils/callIfFunction.ts:2:39 - error TS2349: This expression is not callable.</div><div> Not all constituents of type '(() => T) | (T & Function)' are callable.</div><div> Type 'T & Function' has no call signatures.</div><div><br></div><div>2 return typeof thing === 'function' ? thing() : thing;</div><div> ~~~~~</div><div><br></div><div>src/utils/collapseSourcemaps.ts:96:7 - error TS2322: Type 'number' is not assignable to type 'undefined'.</div><div><br></div><div>96 <span c
lass="Apple-tab-span" style="white-space:pre"> </span>segment[4] = nameIndex;</div><div> <span class="Apple-tab-span" style="white-space:pre"> </span>~~~~~~~~~~</div><div><br></div><div>src/utils/collapseSourcemaps.ts:96:15 - error TS2493: Tuple type '[number, number, number, number]' of length '4' has no element at index '4'.</div><div><br></div><div>96 <span class="Apple-tab-span" style="white-space:pre"> </span>segment[4] = nameIndex;</div><div> <span class="Apple-tab-span" style="white-space:pre"> </span> ~</div><div><br></div><div>src/watch/index.ts:216:5 - error TS2322: Type 'Set<unknown>' is not assignable to type 'Set<string>'.</div><div> Type 'unknown' is not assignable to type 'string'.</div><div><br></div><div>216 <span class="Apple-tab-span" style="white-space:pre"> </span>this.watched = watched;</div><div> <span class="Apple-tab-span" style="white-spac
e:pre"> </span>~~~~~~~~~~~~</div><div><br></div><div><br></div><div>Found 12 errors.</div><div><br></div><div>Files: 277</div><div>Lines: 120117</div><div>Nodes: 418097</div><div>Identifiers: 159915</div><div>Symbols: 104609</div><div>Types: 9282</div><div>Memory used: 169166K</div><div>I/O read: 0.09s</div><div>I/O write: 0.00s</div><div>Parse time: 1.76s</div><div>Bind time: 0.85s</div><div>Check time: 1.75s</div><div>Emit time: 0.00s</div><div>Total time: 4.36s</div></div><div><br></div><div>node-immutable includes type definitions, but it seems to be not enough. </div><div><br></div><div>It has 'declare module Immutable' though this build is expecting it to be 'declare module immutable' (i in small as opposed to I in caps).</d
iv></div>