<div dir="auto">Thanks. I didn't know about minimum version of pkg-js was needed for backporting. And didn't know about the privacy issue and img/ directory.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 10 Dec 2019, 12:19 am Xavier, <<a href="mailto:yadd@debian.org">yadd@debian.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Le 09/12/2019 à 18:25, abhijith sheheer a écrit :<br>
> node-d3-brush has been updated to 1.1.5 . It passes successfully in<br>
> clean chroot. Also passes test suite and reverse dependencies (node-d3)<br>
> as in ``meta/test`` script.<br>
> Link: <a href="https://salsa.debian.org/js-team/node-d3-brush/commits/master" rel="noreferrer noreferrer" target="_blank">https://salsa.debian.org/js-team/node-d3-brush/commits/master</a><br>
> Needs reviewing and sponsoring.<br>
> P.S: I accidentally pushed to js-tean repo instead of my local project :/<br>
> Thanks in advance.<br>
<br>
Hi,<br>
<br>
built and pushed. However take a look at my changes:<br>
* img/ dir is used by README.md only, then install it using debian/docs<br>
and patch README.md to use them instead of github ones (little<br>
privacy breach)<br>
* don't insert pkg-js-tools auto installed files in debian/install<br>
* require a minimal version of pkg-js-tools (> 0.8), else backports<br>
will fail<br>
* always verify package using "cme check dpkg": it gave<br>
- unneeded build dependency versions<br>
- bad license name in debian/copyright<br>
<br>
Cheers,<br>
Xavier<br>
</blockquote></div>