<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, 18 Jan 2020 at 01:06, Xavier <<a href="mailto:yadd@debian.org">yadd@debian.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Le 17/01/2020 à 18:55, Nilesh Patra a écrit :<br>
> <br>
> On Fri, 17 Jan 2020 at 05:02, Pirate Praveen <<a href="mailto:praveen@onenetbeyond.org" target="_blank">praveen@onenetbeyond.org</a><br>
> <mailto:<a href="mailto:praveen@onenetbeyond.org" target="_blank">praveen@onenetbeyond.org</a>>> wrote:<br>
> <br>
> On വെ, Jan 17, 2020 at 07:33, Paolo Greppi <<a href="mailto:paolo.greppi@libpf.com" target="_blank">paolo.greppi@libpf.com</a><br>
> <mailto:<a href="mailto:paolo.greppi@libpf.com" target="_blank">paolo.greppi@libpf.com</a>>><br>
> wrote:<br>
> > Il 16/01/20 20:35, Pirate Praveen ha scritto:<br>
> >><br>
> >><br>
> >> On വ്യാ, Jan 16, 2020 at 13:27, Nilesh Patra<br>
> >> <<a href="mailto:npatra974@gmail.com" target="_blank">npatra974@gmail.com</a> <mailto:<a href="mailto:npatra974@gmail.com" target="_blank">npatra974@gmail.com</a>>> wrote:<br>
> >>> Hi,<br>
> >>> I had been lately seeing discussions in the list regarding<br>
> >>> requiring transition for nodejs-12 to unstable. I tested all the<br>
> >>> reverse depends and this is the list of all failing<br>
> >>> reverse-depends[1] and the repository[2] contains all the<br>
> >>> individual logs(for all reverse-depends) for convenience.<br>
> >>> Also rebuilt the reverse-build-depends and this[3] is the list of<br>
> >>> depends that fail and the individual logs are in the same<br>
> >>> repository[4]<br>
> >>><br>
> >>> [1];<br>
> >>><br>
> <a href="https://git.fosscommunity.in/gi-boi/nodejs_autopkgtest_results/blob/master/rdeps" rel="noreferrer" target="_blank">https://git.fosscommunity.in/gi-boi/nodejs_autopkgtest_results/blob/master/rdeps</a><br>
> >>> [2]:<br>
> >>> <a href="https://git.fosscommunity.in/gi-boi/nodejs_autopkgtest_results/" rel="noreferrer" target="_blank">https://git.fosscommunity.in/gi-boi/nodejs_autopkgtest_results/</a><br>
> >>> [3]:<br>
> >>><br>
> <a href="https://git.fosscommunity.in/gi-boi/nodejs_rebuild_results/blob/master/rebuild_deps" rel="noreferrer" target="_blank">https://git.fosscommunity.in/gi-boi/nodejs_rebuild_results/blob/master/rebuild_deps</a><br>
> >>> [4]: <a href="https://git.fosscommunity.in/gi-boi/nodejs_rebuild_results/" rel="noreferrer" target="_blank">https://git.fosscommunity.in/gi-boi/nodejs_rebuild_results/</a><br>
> >>><br>
> <br>
> [..]<br>
> <br>
> >> Thanks a lot Nilesh for doing it. This is really helpful.<br>
> >> Some the failures may be unrelated to nodejs 12 change, for example<br>
> >> <a href="https://tracker.debian.org/pkg/node-dagre-layout" rel="noreferrer" target="_blank">https://tracker.debian.org/pkg/node-dagre-layout</a> this is already<br>
> >> failing (I think thanks to /usr/lib to /usr/share migration).<br>
> >> Similarly for autopkgtest. So among the packages that failed, we<br>
> >> need to find out which of them are already failing (we can get this<br>
> >> information from <a href="http://tracker.debian.org" rel="noreferrer" target="_blank">tracker.debian.org</a> <<a href="http://tracker.debian.org" rel="noreferrer" target="_blank">http://tracker.debian.org</a>>).<br>
> >><br>
> >>> Thanks and Regards<br>
> >>> Nilesh<br>
> ><br>
> > Hi Nilesh and thanks for the good work.<br>
> ><br>
> > For nodejs_autopkgtest_results, of the 1288 logs only 74 contain the<br>
> > string 'FAIL non-zero exit status' (see attached<br>
> > nodejs_autopkgtest_results-failed).<br>
> > I propose to mass-file bugs against each of them for easier tracking.<br>
> <br>
> I think a wiki page might be simpler at least for first pass.<br>
> See transition of rails 5 for example<br>
> <a href="https://salsa.debian.org/ruby-team/rails/-/wikis/Transition-to-Rails-5.2-for-Debian-Buster" rel="noreferrer" target="_blank">https://salsa.debian.org/ruby-team/rails/-/wikis/Transition-to-Rails-5.2-for-Debian-Buster</a><br>
> <br>
> For packaes that can't be fixed easily we can file bugs.<br>
> <br>
> > For nodejs_rebuild_results, of the 1168 logs only the 62 in the<br>
> > rebdeps file actually failed.<br>
> > Some may be false positives as suggested by Praveen; had you used<br>
> > ratt [1] you could have told it to retry the failing builds without<br>
> > the new package (in this case nodejs 12), this would exclude most of<br>
> > those that are already failing.<br>
> > Who feels like doing it manually now for the 62 failing builds ?<br>
> <br>
> ><br>
> Once we have wiki, people can take ownership of a subset and look at<br>
> specific packages (dividing the whole work).<br>
> <br>
> <br>
> I have created the wiki page here[1] with relevant reverse and reverse<br>
> build depends. Updated the autopkgtest failures as per Paolo's list(74<br>
> in number). The logs are available for individual logs for convenience<br>
> as well.(marked the mail containing links above)<br>
> <br>
> [1]:<br>
> <a href="https://salsa.debian.org/js-team/nodejs/-/wikis/Transition-to-Nodejs-12-for-Debian-Unstable" rel="noreferrer" target="_blank">https://salsa.debian.org/js-team/nodejs/-/wikis/Transition-to-Nodejs-12-for-Debian-Unstable</a><br>
> <br>
> Thanks and Regards<br>
> Nilesh<br>
<br>
Hi,<br>
<br>
node-tap is ready, was just an output problem. (I forgot to bring my<br>
Yubikey, then I'm unable to push it for now. NB: can be pushed directly<br>
to unstable: just 3 tests disabled)<br>
<br>
Cheers,<br>
Xavier<br></blockquote><div><br></div><div>Hi,</div><div><br></div><div>I was trying to fix node-node-sass to build with nodejs-12. In order to do that, I first needed to build node-gyp and node-nan, (both native package and node-node-sass's build-deps) with nodejs-12. While building node-nan with nodejs-12 (and with node-gyp as --extra-package since it is node-nan's build-dep), I encounter several of these:</div><div><pre> 42) test/js/typedarrays-test.js
Error: The module '/<<PKGBUILDDIR>>/test/build/Release/weak2.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 64. This version of Node.js requires
NODE_MODULE_VERSION 72. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).
at Object.Module._extensions..node (internal/modules/cjs/loader.js:1025:18)
at Module.load (internal/modules/cjs/loader.js:815:32)
at Function.Module._load (internal/modules/cjs/loader.js:727:14)
at Module.require (internal/modules/cjs/loader.js:852:19)
at require (internal/modules/cjs/helpers.js:74:18)
at bindings (/usr/lib/nodejs/bindings/bindings.js:76:44)
at Object.<anonymous> (/<<PKGBUILDDIR>>/test/js/weak2-test.js:11:37)
at Module._compile (internal/modules/cjs/loader.js:959:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
at Module.load (internal/modules/cjs/loader.js:815:32)
free(): invalid pointer
test/js/weak-test.js
</pre></div><div><br></div><div>I'm not sure why that is the case(expecting old nodejs version), since node-gyp is its only native build-depend. Could someone help understand the problem, and workaround for it?</div><div>Also, node-node-sass builds fine with the current nodejs, (fixed the reproducible-builds error) I have pushed the changes here[1]</div><div><br></div><div>[1]: <a href="https://salsa.debian.org/gi-boi-guest/node-node-sass">https://salsa.debian.org/gi-boi-guest/node-node-sass</a></div></div></div>