<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 28/06/22 21:47, Yadd wrote:<br>
</div>
<blockquote type="cite"
cite="mid:71335058-6035-03d2-b08b-3e0b73f082ac@debian.org">On
28/06/2022 02:05, Vinay wrote:
<br>
<blockquote type="cite">
<br>
On 27/06/22 13:43, Yadd wrote:
<br>
<blockquote type="cite">On 26/06/2022 19:24, Vinay wrote:
<br>
<blockquote type="cite">Hello,
<br>
<br>
Requesting sponsorship for the package node-c8 .
<br>
<br>
Current Version: 7.11.3+dfsg-1 .
<br>
I have made sure the package is lintian clean and build in
clean chroot in sbuild.
<br>
My salsa repo :
<a class="moz-txt-link-freetext" href="https://salsa.debian.org/vinay-keshava/node-c8">https://salsa.debian.org/vinay-keshava/node-c8</a>
<br>
<br>
<br>
Thank You,
<br>
Vinay Keshava <a class="moz-txt-link-rfc2396E" href="mailto:vinaykeshava@disroot.org"><vinaykeshava@disroot.org></a>
<br>
</blockquote>
<br>
Hi,
<br>
</blockquote>
Hello,
<br>
<blockquote type="cite">
<br>
* copyright:
<br>
- missing copyright for lib/source-map-from-file.js (Expat)
<br>
</blockquote>
for the whole lib/* directory?
<br>
</blockquote>
<br>
No, for this specific file. It contains its own copyright
<br>
<br>
<blockquote type="cite">
<blockquote type="cite">* instead of overriding dh_install,
simply drop debian/nodejs/links </blockquote>
just rm -rf debian/nodejs/links ?
<br>
</blockquote>
<br>
Yes, then nothing will be installed into /usr/bin
<br>
<br>
<blockquote type="cite">
<blockquote type="cite">* clean debian/changelog: only the first
line is useful
<br>
* build-dependencies:
<br>
- replace node-jest by jest
<br>
- drop test dependency to node-istanbul (dependency of jest)
<br>
- drop test dependency to jest: you didn't enable test
because you
<br>
dropped bin directory, why ? It is not a file with any
DFSG problem
<br>
- you also dropped some other fixture files, why ? You can
override
<br>
lintian warnings here: files are little and readable (even
if
<br>
serialized)
<br>
- Note also that test has to be launched using mocha, not
jest
<br>
</blockquote>
<br>
For test ,the dependency list for chai-jest-snapshot was huge so
dropped the tests
<br>
<a class="moz-txt-link-freetext" href="https://paste.debian.net/1245478/">https://paste.debian.net/1245478/</a>
<br>
<br>
|$ cat debian/tests/pkg-js/test |
<br>
<br>
|TS_NODE_SKIP_PROJECT=true node ./bin/c8.js mocha
--timeout=10000 ./test/*.js |Error: Cannot find module
'chai-jest-snapshot'
<br>
||
<br>
</blockquote>
<br>
Only test/integration.js needs it. Try this test:
<br>
<br>
mocha `ls test/*.js | grep -v test/integration`
<br>
</blockquote>
<a class="moz-txt-link-freetext" href="https://paste.debian.net/1245507/">https://paste.debian.net/1245507/</a><br>
<pre>Error: Cannot find module '@istanbuljs/schema/default-extension'
(in lib/parse-args.js and test/parse-args.js)
node-istanbuljs-schema is embedded into node-istanbul
</pre>
<blockquote type="cite"
cite="mid:71335058-6035-03d2-b08b-3e0b73f082ac@debian.org">
<br>
<br>
<blockquote type="cite">
<blockquote type="cite"> - add all dependencies into
build-dependencies with <!nocheck>
<br>
</blockquote>
Few packages are embedded into node-istanbul,jest
<br>
Even the embedded packages should be added to
build-dependencies?
<br>
</blockquote>
<br>
OK, use:
<br>
<br>
Depends: node-bcoe-coverage, node-istanbul, ...
<br>
<br>
Same for build-depends
<br>
<br>
<blockquote type="cite">
<blockquote type="cite">* drop debian/dirs
<br>
* update debian/docs: add CONTRIBUTING.md and
MAINTAINERS_GUIDE.md
<br>
* add lintian overrides (source-map lines are long):
<br>
<br>
# Test data
<br>
source-is-missing *test/*
<br>
source-contains-prebuilt-javascript-object *test/*
<br>
very-long-line-length-in-source-file *test/*
<br>
<br>
</blockquote>
</blockquote>
</blockquote>
</body>
</html>