<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: 0.875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px;
}
body {
font-family: var(--default-regular-font, "GitLab Sans"),-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px; font-family: var(--default-regular-font, "GitLab Sans"),-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<h3 style="margin-top: 20px; margin-bottom: 10px;">
Andrea Bolognani pushed to branch debian/latest at <a href="https://salsa.debian.org/libvirt-team/libvirt">Libvirt Packaging Team / libvirt</a>
</h3>
<h4 style="margin-top: 10px; margin-bottom: 10px;">
Commits:
</h4>
<ul>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/libvirt-team/libvirt/-/commit/345e3ca4eea14da4a540338117f3df481cfd8cc5">345e3ca4</a></strong>
<div>
<span> by Andrea Bolognani </span> <i> at 2024-03-01T02:42:49+01:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #333238; position: relative; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>templates: Drop unnecessary uses of [linux-any]
libvirt-daemon and libvirt-daemon-system are only built on
Linux, so making these lines conditional is unnecessary.
Gbp-Dch: Ignore
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/libvirt-team/libvirt/-/commit/2d2fd1ae383221d5b9132f7b74deb826db75656f">2d2fd1ae</a></strong>
<div>
<span> by Andrea Bolognani </span> <i> at 2024-03-01T02:42:53+01:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #333238; position: relative; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>templates: Move from debian/templates/ to debian/
Turns out that years of habit when it comes to editing files
in the debian/ directory are hard to undo :)
Keep the templates in the same directory as everything else.
For *.install, the output files are only generated at build
time so there is no ambiguity and you hardly even notice the
difference compared to before.
For control, the two files being side by side is still not a
big problem, because the suffix can be used to tell the
template apart, and I've noticed that getting used to editing
that one instead of the output file took hardly any time.
Gbp-Dch: Ignore
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/libvirt-team/libvirt/-/commit/1a3a1f61f3f43bd2213d0b6b32351961caf2fbcd">1a3a1f61</a></strong>
<div>
<span> by Andrea Bolognani </span> <i> at 2024-03-01T02:43:46+01:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #333238; position: relative; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>install: Turn all into templates
This makes for a more consistent experience when editing
them, and avoids the churn that would happen in the future
if architecture-dependent files were moved between package,
or were added to packages that didn't have any until then.
The script that processes these templates is fairly fast, so
processing a dozen more doesn't cause a noticeable increase
in build time.
Gbp-Dch: Ignore
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/libvirt-team/libvirt/-/commit/73d94b57ac6025fd9abcb2e79108fe7464f42da6">73d94b57</a></strong>
<div>
<span> by Andrea Bolognani </span> <i> at 2024-03-06T23:20:42+01:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #333238; position: relative; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>scripts: Use better name for variable
It's not used for generic "variables", but to store
architectures. Name it accordingly.
Gbp-Dch: Ignore
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/libvirt-team/libvirt/-/commit/f5d3d2c6310127f052bd6958af40f4fdda832f25">f5d3d2c6</a></strong>
<div>
<span> by Andrea Bolognani </span> <i> at 2024-03-06T23:22:19+01:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #333238; position: relative; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>scripts: Use pathlib more
Instead of performing string manipulation, use pathlib for
semantic access to the various parts of each path.
Gbp-Dch: Ignore
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/libvirt-team/libvirt/-/commit/03fb4b424bb845f4d66e9f78f3649de551f2d750">03fb4b42</a></strong>
<div>
<span> by Andrea Bolognani </span> <i> at 2024-03-06T23:23:24+01:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #333238; position: relative; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>scripts: Sort templates before processing them
It just makes for nicer output.
Gbp-Dch: Ignore
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/libvirt-team/libvirt/-/commit/806dea6354e3530ce7be9cd4e6d7dc4fcb41f50f">806dea63</a></strong>
<div>
<span> by Andrea Bolognani </span> <i> at 2024-03-06T23:23:57+01:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #333238; position: relative; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>scripts: Error out on unknown suffix
Make the script robust against random packaging files being
turned into templates without implementing proper handling
for them first.
Gbp-Dch: Ignored
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/libvirt-team/libvirt/-/commit/66afacc556720ff37c801bbd36195d0cad7f7591">66afacc5</a></strong>
<div>
<span> by Andrea Bolognani </span> <i> at 2024-03-06T23:24:56+01:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #333238; position: relative; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>scripts: Make it possible to turn maintscripts into templates
Maintainer scripts are supposed to be completely stand-alone,
so it's not possible to create a "library" of common code.
We still need to perform the same operations in the context of
several binary packages though, so code sharing is still
happening - it just takes the crude form of copy and paste.
Since we are already processing templates at build time,
however, we can extend the existing tooling to work on
maintainer scripts too.
The idea is fairly simple: we can have a single file that
contains various shell snippets, each delimited by specific
markers and assigned a unique name; then, in each maintainer
script, we can inject the snippets that we need, avoiding
duplication.
Gbp-Dch: Ignore
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/libvirt-team/libvirt/-/commit/cde6d3e45fbad41ff9ac7df08fa6e46cfdcdb9ec">cde6d3e4</a></strong>
<div>
<span> by Andrea Bolognani </span> <i> at 2024-03-06T23:34:34+01:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #333238; position: relative; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>templates: Turn all maintscripts into templates
No actual change for now, just setting the stage for what's
to come.
Gbp-Dch: Ignore
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://salsa.debian.org/libvirt-team/libvirt/-/commit/e99fa4e6f153f27d81b79b2019073a52aee83a84">e99fa4e6</a></strong>
<div>
<span> by Andrea Bolognani </span> <i> at 2024-03-06T23:39:33+01:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #333238; position: relative; font-family: var(--default-mono-font, "GitLab Mono"),"JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>templates: Adopt across maintscripts
This massively reduces code duplication and will make it a
lot easier to roll out changes if necessary.
Gbp-Dch: Ignore
</pre>
</li>
</ul>
<h4 style="margin-top: 10px; margin-bottom: 10px;">
30 changed files:
</h4>
<ul>
<li class="file-stats">
<a href="#b92c9d7f6a1fe2f439cb4bef6011394658166981">
debian/.gitignore
</a>
</li>
<li class="file-stats">
<a href="#cf9802e192b48f765b1b5c8268d550d89c933053">
debian/README.source
</a>
</li>
<li class="file-stats">
<a href="#b023be67fea6750351b07b7b6e34198f7685da83">
debian/templates/control.in
→
debian/control.in
</a>
</li>
<li class="file-stats">
<a href="#a90b1322fe591b76464801d87ea084c7e9e80b26">
debian/libnss-libvirt.install
→
debian/libnss-libvirt.install.in
</a>
</li>
<li class="file-stats">
<a href="#e1b7ef5088842df84a9dc6975a554603e2f85e65">
debian/libvirt-clients-qemu.install
→
debian/libvirt-clients-qemu.install.in
</a>
</li>
<li class="file-stats">
<a href="#0b49b68528ccd3dad409b404d947ec5e28ba21ac">
debian/templates/libvirt-clients.install.in
→
debian/libvirt-clients.install.in
</a>
</li>
<li class="file-stats">
<a href="#6a5bfccec09b86d20ab0dbc0a73dab066a4ffdef">
debian/libvirt-clients.postrm
→
debian/libvirt-clients.postrm.in
</a>
</li>
<li class="file-stats">
<a href="#fa48ee54c4b9c095e39c7b635cb52479c445fa40">
debian/libvirt-clients.preinst
→
debian/libvirt-clients.preinst.in
</a>
</li>
<li class="file-stats">
<a href="#b73b2fc5f114b7b46eeeef0abd3acf4767638f45">
debian/libvirt-daemon-config-network.install
→
debian/libvirt-daemon-config-network.install.in
</a>
</li>
<li class="file-stats">
<a href="#f7186eaed5a4214a5e7dbc8b60caf9156282ed2d">
<span class="new-file">
+
debian/libvirt-daemon-config-network.postinst.in
</span>
</a>
</li>
<li class="file-stats">
<a href="#199d8d43767e626cb9b84eb0769f4f289464e085">
debian/libvirt-daemon-config-network.postrm
→
debian/libvirt-daemon-config-network.postrm.in
</a>
</li>
<li class="file-stats">
<a href="#aad117a8fbae758c39f244ae3fc5d19ccffda25e">
debian/libvirt-daemon-config-nwfilter.install
→
debian/libvirt-daemon-config-nwfilter.install.in
</a>
</li>
<li class="file-stats">
<a href="#1e5272c2eea736ef0395f39035d08eb2ae0937bb">
debian/libvirt-daemon-config-nwfilter.postinst
→
debian/libvirt-daemon-config-nwfilter.postinst.in
</a>
</li>
<li class="file-stats">
<a href="#5e668e06e12fb9aa39941ec746886b44348f0cc5">
debian/libvirt-daemon-config-nwfilter.postrm
→
debian/libvirt-daemon-config-nwfilter.postrm.in
</a>
</li>
<li class="file-stats">
<a href="#8e40f5ebe127a6d92dbc82df65eacdc11fbde102">
debian/libvirt-daemon-driver-lxc.install
→
debian/libvirt-daemon-driver-lxc.install.in
</a>
</li>
<li class="file-stats">
<a href="#bbd1f49eb16bf057c9c1324f9e54424bb9e1b0c2">
debian/libvirt-daemon-driver-qemu.install
→
debian/libvirt-daemon-driver-qemu.install.in
</a>
</li>
<li class="file-stats">
<a href="#814ade726c23ede52c852e00e5ab626458581a39">
debian/libvirt-daemon-driver-storage-gluster.install
→
debian/libvirt-daemon-driver-storage-gluster.install.in
</a>
</li>
<li class="file-stats">
<a href="#b7e99586f9f3df127790ced31d2df2f2aae65c5a">
debian/libvirt-daemon-driver-storage-iscsi-direct.install
→
debian/libvirt-daemon-driver-storage-iscsi-direct.install.in
</a>
</li>
<li class="file-stats">
<a href="#ad12807c6afdc1a67aab7f180ed8fc6d47d0af75">
debian/libvirt-daemon-driver-storage-rbd.install
→
debian/libvirt-daemon-driver-storage-rbd.install.in
</a>
</li>
<li class="file-stats">
<a href="#96ebd19962cf2428ddf5197a1b5f72bfbf85e23a">
debian/libvirt-daemon-driver-storage-zfs.install
→
debian/libvirt-daemon-driver-storage-zfs.install.in
</a>
</li>
<li class="file-stats">
<a href="#aeeda6b8583907445249755651beaceca29c759f">
debian/libvirt-daemon-driver-vbox.install
→
debian/libvirt-daemon-driver-vbox.install.in
</a>
</li>
<li class="file-stats">
<a href="#423e45a7bf96da4cc2692038abc6498dd5e04ae6">
debian/libvirt-daemon-driver-xen.install
→
debian/libvirt-daemon-driver-xen.install.in
</a>
</li>
<li class="file-stats">
<a href="#cb4f247834c3767912ef1df7b74d756f94a14b25">
debian/templates/libvirt-daemon-system.install.in
→
debian/libvirt-daemon-system.install.in
</a>
</li>
<li class="file-stats">
<a href="#2a9c887e1f505b918c8647164b5608b272c308a1">
debian/libvirt-daemon-system.postinst
→
debian/libvirt-daemon-system.postinst.in
</a>
</li>
<li class="file-stats">
<a href="#6cc9d3a7c0c7ed165ee873b103da0809c8544f45">
debian/libvirt-daemon-system.postrm
→
debian/libvirt-daemon-system.postrm.in
</a>
</li>
<li class="file-stats">
<a href="#c96ed79197c11b6f5d9018d4c667a1346484779f">
debian/libvirt-daemon-system.preinst
→
debian/libvirt-daemon-system.preinst.in
</a>
</li>
<li class="file-stats">
<a href="#bd138dc24c3aa6e3889d107deaa02e28ee2458b3">
debian/templates/libvirt-daemon.install.in
→
debian/libvirt-daemon.install.in
</a>
</li>
<li class="file-stats">
<a href="#d6b8168b575677a08766efd1db42b048bbe7bfb1">
debian/libvirt-dev.install
→
debian/libvirt-dev.install.in
</a>
</li>
<li class="file-stats">
<a href="#1f57dd2197d70c14f746e57cc46c4048e73e4102">
debian/libvirt-l10n.install
→
debian/libvirt-l10n.install.in
</a>
</li>
<li class="file-stats">
<a href="#322f8a90734b7c2b6ce07eb543b0900524541438">
debian/libvirt-login-shell.install
→
debian/libvirt-login-shell.install.in
</a>
</li>
</ul>
<h5 style="margin-top: 10px; margin-bottom: 10px; font-size: 0.875rem;">
The diff was not included because it is too large.
</h5>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
<a href="https://salsa.debian.org/libvirt-team/libvirt/-/compare/9891c49650eb5e8a9e5987800905e1e35dcee08e...e99fa4e6f153f27d81b79b2019073a52aee83a84">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://salsa.debian.org">salsa.debian.org</a>. <a href="https://salsa.debian.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://salsa.debian.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
</p>
</div>
</body>
</html>