[Pkg-libvirt-maintainers] Fwd: PATCH: Correct pygrub path in virtinst

[Marco Sinhoreli]

On Fri, Apr 25, 2008 at 4:14 AM, Guido Günther <agx at sigxcpu.org> wrote:
> Hi Marco,
>
> On Thu, Apr 24, 2008 at 09:52:55PM -0300, Marco Sinhoreli wrote:
>  > I detect that the virtinst not is with the correct path to pygrub and
>  > hvmloader used by Xen. It cause an error in virtinst/virt-manager to
>  > install any virtual machines.
>  > Attached a patch to correct it.
>  Could you ask the xen maintainers to symlink pygrub to /usr/bin?

It is an idea. I can ask to them.

>  Otherwise we'd have to adjust the patch with every xen release.

Example files in directory test, is hardcoded, meanwhile, the python
scripts, I included a dinamic routine as below to ajust the pygrub and
hvmloader path:

-            osblob += "  </os>\n"
-            osblob += "  <bootloader>/usr/bin/pygrub</bootloader>"
+            getXenVersionCmd = 'printf
$(/usr/lib/xen-common/bin/xen-utils-version)'
+            put, get = os.popen4(getXenVersionCmd)
+            xenVersion = get.readlines()

+            osblob += "  </os>\n"
+            osblob += "
<bootloader>/usr/lib/xen-%s/bin/pygrub</bootloader>" % (xenVersion[0])
+

I think that, it is sufficient to we'd have to ajust the patch in
futures xen releases.

Cheers,

--
Marco Sinhoreli