[Pkg-Mali-devel] Updating mali-midgard to build against Linux 4.18

[Wookey]

On 2018-12-19 03:22 +0000, Wookey wrote:
> On 2018-12-14 20:57 +0100, Rohan Garg wrote:
> > Hi
> > I've been working on getting the graphics stack up on the Firefly
> > RK3399 (AIO3399J variant) and have made some pretty significant
> > progress so far. I've filed [1] as a starting point to get the DKMS
> > module building on Debian.
> 
> Thanks for this work. As I said on IRC I've fettled the patches a bit
> to get things applying properly. I reckon it's a good idea to add '9'
> to the PATCH_MATCH as all these patches should be needed on 4.19 too,
> and hopefully they stil apply.
> 
> I'll do an upload as soon as I've checked it still works on my firefly.

OK. I've not actually checked this, but I have checked that
it builds OK on 4.16 and 4.18 kernels and has the right patches.

So I've just uploaded a 16.0+pristine-3. Tell me if it works for you.

Now I have one issue undealt-with that I may just be being dim about.

Someone (it might have been you Rohan) pointed out that we also need a
fix so tha tthings still work when the both drivers (the governor
driver and the driver that call devfreq_add_device) are built as
modules).

However that patch needs to patch the kernel source:
(drivers/devfreq/devfreq.c) not the mali source and rebuild the
kernel. Can dkms do this? It seems to me that it cannot (you
should only need the headers present to build the dkms module, not the
kernel source, and it is only intended to build the installed modules)

So I guess we need to get this patch into the debian kernel to have things work properly. 

I will need an upstream commit to point at to get this into the debian kernel:
+Fixes: 1b5c1be2c88e (PM / devfreq: map devfreq drivers to governor using name)
+Signed-off-by: Enric Balletbo i Serra <enric.balletbo at collabora.com> 

This patch is in the -3 I just uploaded, but commented out in dkms.conf.

Can someone confirm that I understand this correctly: that we can't
fix this ourselves, and need to do it in the kernel?

Wookey
-- 
Principal hats:  Linaro, Debian, Wookware, ARM
http://wookware.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-mali-devel/attachments/20181219/8503f9af/attachment.sig>