Bug#638599: sineshaper: FTBFS with ld --as-needed

[Ilya Barygin]

Package: sineshaper
Version: 0.4.2-6
Severity: normal
Tags: upstream patch
User: debian-gcc at lists.debian.org
Usertags: ld-as-needed

The package fails to build when --as-needed linker option is enabled,
because of incorrect order of parameters passed to ld. Here's a log of
failed build in Ubuntu:
https://launchpadlibrarian.net/76089806/buildlog_ubuntu-oneiric-i386.sineshaper_0.4.2-6_FAILEDTOBUILD.txt.gz

See also
http://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries

The attached patch was used in Ubuntu to fix the problem.
https://launchpad.net/ubuntu/+source/sineshaper/0.4.2-6ubuntu1

-- System Information:
Debian Release: wheezy/sid
  APT prefers oneiric
  APT policy: (500, 'oneiric')
Architecture: i386 (i686)

Kernel: Linux 2.6.38-11-generic (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
-------------- next part --------------
Description: Change order of libraries to enable linking with --as-needed
 option.
Author: Ilya Barygin <barygin at gmail.com>
--- sineshaper-0.4.2.orig/src/sineshaper/Makefile.am
+++ sineshaper-0.4.2/src/sineshaper/Makefile.am
@@ -14,7 +14,7 @@ sineshaper_gtk_SOURCES = \
 	skindial_gtkmm.cpp skindial_gtkmm.hpp \
 	sineshapergui.hpp sineshapergui.cpp \
 	sineshaperports.hpp
-sineshaper_gtk_LDADD = @DSSI_LIBS@ @LIBGLADEMM_LIBS@ @LIBLO_LIBS@ ../common/libdssi_ui.la ../common/libdssi_common.la
+sineshaper_gtk_LDADD = ../common/libdssi_ui.la ../common/libdssi_common.la @DSSI_LIBS@ @LIBGLADEMM_LIBS@ @LIBLO_LIBS@
 sineshaper_gtk_CXXFLAGS = @LIBLO_CFLAGS@ @DSSI_CFLAGS@ -D_XOPEN_SOURCE @LIBGLADEMM_CFLAGS@ -DINSTALL_DIR=\"$(dssidir)\" -I../common/ -I../gui-components
 
 dist_bin_SCRIPTS = sineshaper.sh
--- sineshaper-0.4.2.orig/src/sineshaper/Makefile.in
+++ sineshaper-0.4.2/src/sineshaper/Makefile.in
@@ -220,7 +220,7 @@ sineshaper_gtk_SOURCES = \
 	sineshapergui.hpp sineshapergui.cpp \
 	sineshaperports.hpp
 
-sineshaper_gtk_LDADD = @DSSI_LIBS@ @LIBGLADEMM_LIBS@ @LIBLO_LIBS@ ../common/libdssi_ui.la ../common/libdssi_common.la
+sineshaper_gtk_LDADD = ../common/libdssi_ui.la ../common/libdssi_common.la @DSSI_LIBS@ @LIBGLADEMM_LIBS@ @LIBLO_LIBS@
 sineshaper_gtk_CXXFLAGS = @LIBLO_CFLAGS@ @DSSI_CFLAGS@ -D_XOPEN_SOURCE @LIBGLADEMM_CFLAGS@ -DINSTALL_DIR=\"$(dssidir)\" -I../common/ -I../gui-components
 dist_bin_SCRIPTS = sineshaper.sh
 gui_DATA = sineshaper.glade dial.png pixmaps/dummydial.png pixmaps/sineshaper.png presets