compat 8 vs compat 9

[Jaromír Mikeš]

2013/8/19 Sebastian Ramacher <sramacher at debian.org>

>
>
> > Here jack-capture:
> >
> > gcc -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat
> > -Werror=format-security -O2 -DVERSION=\"0.9.71\" -Wall -Wextra
> -Wno-unused
> > jack_capture.c vringbuffer.c upwaker.c osc.c -o jack_capture -Wl,-z,relro
> > -ljack -lsndfile -lm -lpthread -lrt `cat config_flags`
> > jack_capture.c: In function 'autoincrease_callback':
> > jack_capture.c:336:49: warning: unused parameter 'vrb'
> [-Wunused-parameter]
> >  static int autoincrease_callback(
> > vringbuffer_t *vrb, bool first_call, int reading_size, int writing_size){
> >                                                  ^
> > jack_capture.c:336:75: warning: unused parameter 'reading_size'
> > [-Wunused-parameter]
> >  static int autoincrease_callback(vringbuffer_t *vrb, bool first_call,
> int
> > reading_size, int writing_size){
> >
>    ^
> > jack_capture.c: In function 'print_console':
> > jack_capture.c:663:9: error: format not a string literal and no format
> > arguments [-Werror=format-security]
> >          printf(vol);
> >          ^
> > jack_capture.c:671:9: error: format not a string literal and no format
>
> Here printf("%s", vol); should be enough.
>

Unfortunately this is not enough :(

gcc -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat
-Werror=format-security -O2 -DVERSION=\"0.9.71\" -Wall -Wextra -Wno-unused
jack_capture.c vringbuffer.c upwaker.c osc.c -o jack_capture -Wl,-z,relro
-ljack -lsndfile -lm -lpthread -lrt `cat config_flags`
jack_capture.c: In function 'autoincrease_callback':
jack_capture.c:336:49: warning: unused parameter 'vrb' [-Wunused-parameter]
 static int autoincrease_callback(vringbuffer_t *vrb, bool first_call, int
reading_size, int writing_size){
                                                 ^
jack_capture.c:336:75: warning: unused parameter 'reading_size'
[-Wunused-parameter]
 static int autoincrease_callback(vringbuffer_t *vrb, bool first_call, int
reading_size, int writing_size){
                                                                           ^
jack_capture.c: In function 'print_console':
jack_capture.c:671:9: error: format not a string literal and no format
arguments [-Werror=format-security]
         printf(vol+4+pos);
         ^
jack_capture.c: In function 'helper_thread_func':
jack_capture.c:760:39: warning: unused parameter 'arg' [-Wunused-parameter]
 static void *helper_thread_func(void *arg){
                                       ^
jack_capture.c: In function 'wait_child':
jack_capture.c:944:28: warning: unused parameter 'sig' [-Wunused-parameter]
 static void wait_child(int sig){
                            ^
jack_capture.c: In function 'process':
jack_capture.c:1646:50: warning: unused parameter 'arg' [-Wunused-parameter]
 static int process(jack_nframes_t nframes, void *arg){
                                                  ^
jack_capture.c: In function 'xrun':
jack_capture.c:1721:23: warning: unused parameter 'arg' [-Wunused-parameter]
 static int xrun(void *arg){
                       ^
jack_capture.c: In function 'connection_thread':
jack_capture.c:1931:38: warning: unused parameter 'arg' [-Wunused-parameter]
 static void* connection_thread(void *arg){
                                      ^
jack_capture.c: In function 'graphordercallback':
jack_capture.c:1973:37: warning: unused parameter 'arg' [-Wunused-parameter]
 static int graphordercallback(void *arg){
                                     ^
jack_capture.c: In function 'freewheelcallback':
jack_capture.c:1979:51: warning: unused parameter 'arg' [-Wunused-parameter]
 static void freewheelcallback(int starting, void *arg){
                                                   ^
jack_capture.c: In function 'jack_latency_cb':
jack_capture.c:1990:70: warning: unused parameter 'arg' [-Wunused-parameter]
 static void jack_latency_cb(jack_latency_callback_mode_t mode, void *arg) {
                                                                      ^
jack_capture.c: In function 'finish':
jack_capture.c:2034:24: warning: unused parameter 'sig' [-Wunused-parameter]
 static void finish(int sig){
                        ^
jack_capture.c: In function 'jack_shutdown':
jack_capture.c:2039:33: warning: unused parameter 'arg' [-Wunused-parameter]
 static void jack_shutdown(void *arg){
                                 ^
jack_capture.c: In function 'keypress_func':
jack_capture.c:2076:34: warning: unused parameter 'arg' [-Wunused-parameter]
 static void* keypress_func(void* arg){
                                  ^
cc1: some warnings being treated as errors
osc.c: In function 'oscb_tm_start':
osc.c:46:50: warning: unused parameter 'types' [-Wunused-parameter]
 int oscb_tm_start (const char *path, const char *types, lo_arg **argv, int
argc, lo_message msg, void *user_data){
                                                  ^
osc.c:46:76: warning: unused parameter 'argc' [-Wunused-parameter]
 int oscb_tm_start (const char *path, const char *types, lo_arg **argv, int
argc, lo_message msg, void *user_data){

^
osc.c:46:93: warning: unused parameter 'msg' [-Wunused-parameter]
 int oscb_tm_start (const char *path, const char *types, lo_arg **argv, int
argc, lo_message msg, void *user_data){

^
osc.c:46:104: warning: unused parameter 'user_data' [-Wunused-parameter]
 int oscb_tm_start (const char *path, const char *types, lo_arg **argv, int
argc, lo_message msg, void *user_data){

^
osc.c: In function 'oscb_tm_stop':
osc.c:52:49: warning: unused parameter 'types' [-Wunused-parameter]
 int oscb_tm_stop (const char *path, const char *types, lo_arg **argv, int
argc, lo_message msg, void *user_data){
                                                 ^
osc.c:52:75: warning: unused parameter 'argc' [-Wunused-parameter]
 int oscb_tm_stop (const char *path, const char *types, lo_arg **argv, int
argc, lo_message msg, void *user_data){
                                                                           ^
osc.c:52:92: warning: unused parameter 'msg' [-Wunused-parameter]
 int oscb_tm_stop (const char *path, const char *types, lo_arg **argv, int
argc, lo_message msg, void *user_data){

^
osc.c:52:103: warning: unused parameter 'user_data' [-Wunused-parameter]
 int oscb_tm_stop (const char *path, const char *types, lo_arg **argv, int
argc, lo_message msg, void *user_data){

^
osc.c: In function 'oscb_stop':
osc.c:58:46: warning: unused parameter 'types' [-Wunused-parameter]
 int oscb_stop (const char *path, const char *types, lo_arg **argv, int
argc, lo_message msg, void *user_data){
                                              ^
osc.c:58:62: warning: unused parameter 'argv' [-Wunused-parameter]
 int oscb_stop (const char *path, const char *types, lo_arg **argv, int
argc, lo_message msg, void *user_data){
                                                              ^
osc.c:58:72: warning: unused parameter 'argc' [-Wunused-parameter]
 int oscb_stop (const char *path, const char *types, lo_arg **argv, int
argc, lo_message msg, void *user_data){
                                                                        ^
osc.c:58:89: warning: unused parameter 'msg' [-Wunused-parameter]
 int oscb_stop (const char *path, const char *types, lo_arg **argv, int
argc, lo_message msg, void *user_data){

^
osc.c:58:100: warning: unused parameter 'user_data' [-Wunused-parameter]
 int oscb_stop (const char *path, const char *types, lo_arg **argv, int
argc, lo_message msg, void *user_data){

^
osc.c: In function 'oscb_frotate':
osc.c:64:49: warning: unused parameter 'types' [-Wunused-parameter]
 int oscb_frotate (const char *path, const char *types, lo_arg **argv, int
argc, lo_message msg, void *user_data){
                                                 ^
osc.c:64:65: warning: unused parameter 'argv' [-Wunused-parameter]
 int oscb_frotate (const char *path, const char *types, lo_arg **argv, int
argc, lo_message msg, void *user_data){
                                                                 ^
osc.c:64:75: warning: unused parameter 'argc' [-Wunused-parameter]
 int oscb_frotate (const char *path, const char *types, lo_arg **argv, int
argc, lo_message msg, void *user_data){
                                                                           ^
osc.c:64:92: warning: unused parameter 'msg' [-Wunused-parameter]
 int oscb_frotate (const char *path, const char *types, lo_arg **argv, int
argc, lo_message msg, void *user_data){

^
osc.c:64:103: warning: unused parameter 'user_data' [-Wunused-parameter]
 int oscb_frotate (const char *path, const char *types, lo_arg **argv, int
argc, lo_message msg, void *user_data){

^
make[1]: *** [jack_capture] Error 1
make[1]: Leaving directory `/tmp/buildd/jack-capture-0.9.71'
dh_auto_build: make -j1 returned exit code 2
make: *** [build] Error 2

Any idea?

regards

mira
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20130819/3e6158ef/attachment-0001.html>