Bug#800454: yoshimi: please remove unused build-dep on libjpeg9-dev

Graham Inggs ginggs at debian.org
Tue Sep 29 16:18:35 UTC 2015


Source: yoshimi
Version: 1.3.5.1-1
Tags: patch

Hi Maintainer

Please remove the unused build dependency on libjpeg9-dev from yoshimi.
It is not possible to synchronize yoshimi directly into Ubuntu as 
libjpeg9-dev does not exist there.
In Debian and Ubuntu the libjpeg build dependency should be unversioned, 
i.e. libjpeg-dev, see [1] [2].
However, since yoshimi does not need this build dependency, it can be 
removed altogether.

While looking at the packaging, I noticed the following line in 
debian/rules:

LDFLAGS+=-Wl,--as-needed

This has no effect.  What you want is this (see [3]):

export DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed

Lastly, the generated file src/version.txt is not removed after 
building, this prevents the package from being built twice in a row.

Please see the attached patch that makes all of these changes.

Regards
Graham


[1] https://wiki.debian.org/LJTTransition
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=717076#235
[3] https://wiki.debian.org/HardeningWalkthrough#debhelper_9

-------------- next part --------------
A non-text attachment was scrubbed...
Name: yoshimi-libjpeg.diff
Type: text/x-diff
Size: 1016 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20150929/b63f6a4d/attachment.diff>


More information about the pkg-multimedia-maintainers mailing list