Bug#897745: etl: ftbfs with GCC-8

[Matthias Klose]

Package: src:etl
Version: 1.2.1-0.1
Severity: normal
Tags: sid buster
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-8

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-8/g++-8, but succeeds to build with gcc-7/g++-7. The
severity of this report will be raised before the buster release.

The full build log can be found at:
http://aws-logs.debian.net/2018/05/01/gcc8/etl_1.2.1-0.1_unstable_gcc8.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 8, either set CC=gcc-8 CXX=g++-8 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-8/porting_to.html

[...]
pen.cpp:113:10: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
   printf("FAILURE! "__FILE__"@%d: iterator_x inconsistency\n",__LINE__);
          ^
pen.cpp:228:10: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
   printf("Um..... malloc failure on line %d of "__FILE__"...\n",__LINE__);
          ^
pen.cpp:284:10: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
   printf("FAILURE! "__FILE__"@%d: blur result contained %d bad values\n",__LINE__,bad_values);
          ^
In file included from ../ETL/pen:32,
                 from pen.cpp:31:
../ETL/_pen.h: In member function 'etl::generic_pen<T, AT>::difference_type::value_type& etl::generic_pen<T, AT>::difference_type::operator[](int) const':
../ETL/_pen.h:139:51: error: binding reference of type 'etl::generic_pen<T, AT>::difference_type::value_type&' {aka 'int&'} to 'const value_type' {aka 'const int'} discards qualifiers
   value_type &operator[](int i)const { return i?y:x; }
                                                   ^
pen.cpp: In function 'int generic_pen_test(int, int)':
pen.cpp:47:2: warning: 'template<class> class std::auto_ptr' is deprecated [-Wdeprecated-declarations]
  auto_ptr<float> data(new float[w*h]);
  ^~~~~~~~
In file included from /usr/include/c++/8/memory:80,
                 from pen.cpp:29:
/usr/include/c++/8/bits/unique_ptr.h:53:28: note: declared here
   template<typename> class auto_ptr;
                            ^~~~~~~~
pen.cpp: In function 'int box_blur_test()':
pen.cpp:224:2: warning: 'template<class> class std::auto_ptr' is deprecated [-Wdeprecated-declarations]
  auto_ptr<boxblur_float> data(new boxblur_float[w*h]);
  ^~~~~~~~
In file included from /usr/include/c++/8/memory:80,
                 from pen.cpp:29:
/usr/include/c++/8/bits/unique_ptr.h:53:28: note: declared here
   template<typename> class auto_ptr;
                            ^~~~~~~~
pen.cpp:225:2: warning: 'template<class> class std::auto_ptr' is deprecated [-Wdeprecated-declarations]
  auto_ptr<boxblur_float> data2(new boxblur_float[w*h]);
  ^~~~~~~~
In file included from /usr/include/c++/8/memory:80,
                 from pen.cpp:29:
/usr/include/c++/8/bits/unique_ptr.h:53:28: note: declared here
   template<typename> class auto_ptr;
                            ^~~~~~~~
make[3]: *** [Makefile:683: pen.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/test'
make[2]: *** [Makefile:1022: check-am] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/test'
make[1]: *** [Makefile:511: check-recursive] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
make: *** [debian/rules:7: build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2