<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
Hello,<br>
I've looked GIT commits and they in very good shape.<br>
Some observations that rise to my mind:<br>
* I didn't know that one can do [mariadb-10.6] config that is only
for some version of MariaDB is this documented somewhere?<br>
* What is (I admit didn't grep) source_mariadb-10.6.py used for? As
it seems to parse logs..<br>
* In pipeline there is nice upgrade tests.. what Database they are
using or just create database and upgrade. I try to find these Salsa
tests to study them more.<br>
* Ok seems that upstream tests should be fixed as they are borked
currently!<br>
* In future would it be 'convenient' to use just
mariadb-server.postinst and other without 10.6/7/8 suffix. I know
it's just copy with git but there are tags and releases to make sure<br>
that files get into correct place. This just my humble opinion
nothing more.<br>
<br>
Pipeline is actually failing currently in Salsa. I'll compile that
also today and tell if it's success or not. I don't see that much
changes from 10.5 why it shouldn't build.<br>
Tuukka<br>
<code><span class="idiff left right"><span class="file-title-name
gl-word-break-all"></span></span></code>
<div class="moz-cite-prefix">Otto Kekäläinen kirjoitti 21.10.2021
klo 11.02:<br>
</div>
<blockquote type="cite"
cite="mid:CAOU6tABcW_cPv3OYxmzi6WfikueDNB6ZZi48dkqnFugnN2T-4A@mail.gmail.com">
<pre class="moz-quote-pre" wrap="">Hello Stephen!
The package builds fine using dpkg-buildpackage, debuilder,
git-buildpackage or any of the usual Debian tools (as also shown by
the CI pipeline at
<a class="moz-txt-link-freetext" href="https://salsa.debian.org/mariadb-team/mariadb-server/-/pipelines">https://salsa.debian.org/mariadb-team/mariadb-server/-/pipelines</a>). The
logs you sent are incomplete, they just contain the end of the log
without showing what was your starting situation or what were the
first commands you ran after cloning the repository.
Without seeing the full build log it is hard to say what failed in the
build, but I suspect you ran some commands before dpkg-buildpackage
that somehow modified the sources and therefore the build is not clean
anymore or something (but this is just speculation).
On Tue, Oct 19, 2021 at 11:32 AM Stephen <a class="moz-txt-link-rfc2396E" href="mailto:stephen@tha.net"><stephen@tha.net></a> wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
Hi Otto,
I send you a build log which failed when running "dpkg-buildpackage -b". I wasnt sure what next steps to take.
The instructions you gave regarding the failed build command were not really relevant as it was just the last command shown by the build log, although I did try running it manually it also didnt work. Adding your instructions to that manually run command also did not seem to make sense as ../cmake is a directory, yet in the build statement it is the command. Sorry for not providing that further feedback.
At this point Im not sure how to make it build with "dpkg-buildpackage" or if it is simply not expected to work with this command. Should I instead simply not use this command any more to do a package build? Sorry I have not had time to read through the most current build documentation to check.
On Tue, Oct 19, 2021 at 6:42 PM Otto Kekäläinen <a class="moz-txt-link-rfc2396E" href="mailto:otto@kekalainen.net"><otto@kekalainen.net></a> wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
I didn't get any review/feedback yet..
ma 11. lokak. 2021 klo 8.59 Otto Kekäläinen <a class="moz-txt-link-rfc2396E" href="mailto:otto@kekalainen.net"><otto@kekalainen.net></a> kirjoitti:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
Hello!
I recently created a new repository at
<a class="moz-txt-link-freetext" href="https://salsa.debian.org/mariadb-team/mariadb-server">https://salsa.debian.org/mariadb-team/mariadb-server</a> that uses the
DEP-14 repository layout:
<a class="moz-txt-link-freetext" href="https://dep-team.pages.debian.net/deps/dep14/">https://dep-team.pages.debian.net/deps/dep14/</a>
First I imported the current mariadb-10.5 Salsa project on branch
debian/latest and then I imported upstream MariaDB 10.6.4 and did all
the usual QA work needed. This should now be ready for upload to
unstable.
This was a fairly big task I have been doing in steps since August and
there is a possibility that I missed something. Please review all the
recent commits at
<a class="moz-txt-link-freetext" href="https://salsa.debian.org/mariadb-team/mariadb-server/-/commits/debian/latest/debian">https://salsa.debian.org/mariadb-team/mariadb-server/-/commits/debian/latest/debian</a>
and let me know if you spot something.
If you are not a Debian packaging or MariaDB expert, you can still
help by at least proof-reading that there are no obvious mishaps in
the commits.
If there is not much more to fix, I'll upload this the Debian unstable
in the coming days.
- Otto
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
</blockquote>
<pre class="moz-signature" cols="72">--
Tuukka Pasanen
Production Manager
<a class="moz-txt-link-abbreviated" href="mailto:tuukka.pasanen@ilmi.fi">tuukka.pasanen@ilmi.fi</a>
+358 40 7303 216</pre>
</body>
</html>