<html dir="ltr"><head></head><body style="text-align:left; direction:ltr;" bgcolor="#ffffff" text="#2e3436" link="#1b6acb" vlink="#2e3436"><div>Hi Michalis,</div><div><br></div><div><span><pre><pre>On Fri, 2021-02-26 at 03:07 +0100, Michalis Kamburelis wrote:</pre></pre></span></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><pre>1. PasDoc warnings about inability to parse $if -- these will</pre><pre>disappear if you use PasDoc 0.16.0. You can also just ignore them (to</pre><pre>not make CGE update in Debian blocked by PasDoc update in Debian).</pre><pre>They are indeed just warnings, and should not cause PasDoc to exit</pre><pre>with non-zero status. They occur so often, because the construction</pre><pre>with $if is used within castleconf.inc, which is included in all the</pre><pre>units.</pre></blockquote><div>Uploaded ot experimental</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><pre><br></pre><pre>2. PasDoc warnings about invalid links -- my mistake. Take this patch:</pre><a href="https://github.com/castle-engine/castle-engine/commit/7d62f9bd5b97d88ee2fae248eb963c0af1c0c5d1"><pre>https://github.com/castle-engine/castle-engine/commit/7d62f9bd5b97d88ee2fae248eb963c0af1c0c5d1</pre></a><pre><br></pre><pre>. Or simply ignore them, they should not cause PasDoc to exit with</pre><pre>non-zero status. I added a TODO for myself to improve my Jenkins job,</pre><pre>to fail in case of any warnings, so I will spot them immediately in</pre><pre>the future.</pre></blockquote><div>The patch was applied (with modification as it does not apply as is). Please review in <a href="https://salsa.debian.org/pascal-team/castle-game-engine/-/commit/17c62b162421b48628e1d06611f7435786bcf6a1">https://salsa.debian.org/pascal-team/castle-game-engine/-/commit/17c62b162421b48628e1d06611f7435786bcf6a1</a></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><pre><br></pre><pre>3. There is 1 error that actually causes PasDoc to exit with non-zero status:</pre><pre><br></pre><pre> Warning[2]: Error EPasDoc: ./x3d/x3dnodes_prototypes.inc(984):</pre><pre>Unexpected reserved word "end" while parsing unit x3dnodes.pas,</pre><pre>continuing...</pre><pre><br></pre><pre>This is a bug in PasDoc 0.15.0. It is fixed in PasDoc 0.16.0. If you</pre><pre>want to build API docs with older PasDoc 0.15.0, please apply the</pre><pre>attached patch fix-for-pasdoc.0.15.0.patch (it removes a code that is</pre><pre>in practice unused).</pre></blockquote><div>This seems to be fixed by forcing 0.16.0: <a href="https://salsa.debian.org/pascal-team/castle-game-engine/-/commit/72e2d28123ce150f12d284f28f52313aea0e346a">https://salsa.debian.org/pascal-team/castle-game-engine/-/commit/72e2d28123ce150f12d284f28f52313aea0e346a</a></div><div><br></div><div>However a new error spotted. There is a <i><b>./tests/code/common/castleconsoletestrunner.pas </b></i>but it does not find it.</div><div><br></div><pre><font color="#808080">rm -Rf ../reference/</font></pre><pre><font color="#808080">mv html ../reference/</font></pre><pre><font color="#808080">cp -R logo/castle_game_engine_icon.png \</font></pre><pre><font color="#808080"> html-parts/images/ \</font></pre><pre><font color="#808080"> html-parts/castle-engine-website-base/ \</font></pre><pre><font color="#808080"> html-parts/cge-pasdoc.js \</font></pre><pre><font color="#808080"> ../reference/</font></pre><pre><font color="#808080">make[2]: Leaving directory '/build/castle-game-engine-7.0-alpha.1/doc/pasdoc'</font></pre><pre><font color="#808080"># pasdoc create a jquery file, but we link from jquery instead</font></pre><pre><font color="#808080">rm -rf doc/reference/tipuesearch/jquery.min.js</font></pre><pre><font color="#808080">make[1]: Leaving directory '/build/castle-game-engine-7.0-alpha.1'</font></pre><pre><font color="#808080"> debian/rules override_dh_auto_test-arch</font></pre><pre><font color="#808080">make[1]: Entering directory '/build/castle-game-engine-7.0-alpha.1'</font></pre><pre><font color="#808080"># Command basically copied from tests/compile_console.sh while</font></pre><pre><font color="#808080"># making sure that no unit or object files polute the source tree</font></pre><pre><font color="#808080">/usr/bin/fpc -gh -dDEBUG -dTEXT_RUNNER -dNO_WINDOW_SYSTEM \</font></pre><pre><font color="#808080"> -Fuexamples/research_special_rendering_methods/shadow_fields/ \</font></pre><pre><font color="#808080"> -Fuexamples/curves_surfaces/ \</font></pre><pre><font color="#808080"> -FE/build/castle-game-engine-7.0-alpha.1/debian/tmp/tmp \</font></pre><pre><font color="#808080"> @castle-fpc.cfg tests/test_castle_game_engine.lpr</font></pre><pre><font color="#808080">Compiling Debug Version</font></pre><pre><font color="#808080">Compiling Debug Version</font></pre><pre><font color="#808080">Free Pascal Compiler version 3.2.0+dfsg-12 [2021/01/25] for x86_64</font></pre><pre><font color="#808080">Copyright (c) 1993-2020 by Florian Klaempfl and others</font></pre><pre><font color="#808080">Target OS: Linux for x86-64</font></pre><pre><font color="#ff0000">Compiling <b>tests/test_castle_game_engine.lpr</b></font></pre><pre><font color="#ff0000">test_castle_game_engine.lpr(20,3) Fatal: Can't find unit <b>CastleConsoleTestRunner</b> used by <b>test_castle_game_engine</b></font></pre><pre><font color="#ff0000">Fatal: Compilation aborted</font></pre><pre><font color="#808080">Error: /usr/bin/ppcx64 returned an error exitcode</font></pre><pre><font color="#808080">make[1]: *** [debian/rules:118: override_dh_auto_test-arch] Error 1</font></pre><pre><font color="#808080">make[1]: Leaving directory '/build/castle-game-engine-7.0-alpha.1'</font></pre><pre><font color="#808080">make: *** [debian/rules:52: binary] Error 2</font></pre><pre><font color="#808080">dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2</font></pre><pre><br></pre><pre>Can you please propose a patch?</pre><div><div class="-x-evo-signature-wrapper" style="white-space: normal;"><span class="-x-evo-signature" id="1423923852.20958.6@karim"><pre><pre>-- <br></pre>Cheers,
Abou Al Montacir</pre></span></div></div><div></div></body></html>