<html><head></head><body><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;">Hi Paul,</div><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;"><br></div><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;">On Tue, 2021-11-02 at 21:22 +0100, Paul Gevers wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div>...</div><div>I don't follow at all.</div></blockquote><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;">Sorry, I don't catch what do you mean here, probably due to my non native English.</div><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;">Did you not accept the new solution, or is my explanation above not clear at all and confusing? </div><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;">If you don't like the new solution, it is fine with me. We can try to fix the current one. Otherwise, please let me know and I can try to explain it a bit more.</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div> We're doing diversions in maintainer scripts and<br></div><div>we forget to properly keep track of our diversions.</div></blockquote><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;">The list of diverted files is created automatically during the build process in lazarus-src.preinst.[1]</div><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;">The very same list is created for lazarus-src.postrm.[2]</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div> With the new<br></div><div>upstream version, apparently some files got dropped and the knowledge of<br></div><div>the diversions got lost in the process.</div></blockquote><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;">This means that somehow, the lazarus-src.postrm was not called.</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div> I think we can easily manually<br></div><div>drop the diversions now by adding them here [1], while contemplating a<br></div><div>saner and automated way of handling the underlying problem.</div></blockquote><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;">In the current case, lazarus-src.postrm is not called or is called but does not fall in the list of tests we are doing (called with upgrade?).</div><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;">However, in the past we did not remove the old lazarus when the new one is installed (we were able to have 2.0.10 and 2.0.12). Now we allow this only for major releases, not maintenance ones. So next time, soon, when 2.2 will be there, the upgrade will not happen in the same way.</div><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;">So if upgrading from 2.0.10 to 2.0.x we should remove diversions, but not if we go to from 2.0.10 to 2.y with y > 0.</div><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;"><br></div><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;">That was why I proposed to completely replace this mechanism with an other one that let it handled automatically with dpkg, but maybe we can just fix the logic in [3].</div><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;"><br></div><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;">[1] <a href="https://salsa.debian.org/pascal-team/lazarus/-/blob/master/debian/rules#L411">https://salsa.debian.org/pascal-team/lazarus/-/blob/master/debian/rules#L411</a></div><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;">[2] <a href="https://salsa.debian.org/pascal-team/lazarus/-/blob/master/debian/rules#L423">https://salsa.debian.org/pascal-team/lazarus/-/blob/master/debian/rules#L423</a></div><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;">[3] <a href="https://salsa.debian.org/pascal-team/lazarus/-/blob/master/debian/lazarus-src.postrm.in#L7">https://salsa.debian.org/pascal-team/lazarus/-/blob/master/debian/lazarus-src.postrm.in#L7</a></div><div style="caret-color: rgb(46, 52, 54); color: rgb(46, 52, 54); font-family: Cantarell; font-size: 14.666666984558105px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-tap-highlight-color: rgba(0, 0, 0, 0.4); -webkit-text-stroke-width: 0px; text-decoration: none;"><span><pre>-- <br></pre><pre>Cheers,
Abou Al Montacir</pre></span></div></body></html>