Bug#684070: libxml-libxml-perl: lack of error handling in build process means that if there is a problem broken packages are built (rather than a build failure)

[Alessandro Ghedini]

On Tue, Aug 07, 2012 at 08:15:00PM +0200, gregor herrmann wrote:
> On Tue, 07 Aug 2012 19:59:54 +0200, Alessandro Ghedini wrote:
> 
> > > unless (have_library("xml2") or have_library("libxml2")) {
> 
> > > exit 0; # 0 recommended by http://cpantest.grango.org (Notes for CPAN Authors)
> 
> > This is also what happens when using Devel::CheckLib's check_lib_or_exit().
> 
> Oopsie.
> (Nice catch!)
> 
> > Should we fix the packages that use it too?
> 
> I tend to say yes ...

The packages that use check_lib_or_exit() are:

libaudio-tagger-perl
libauthen-krb5-simple-perl
libdata-structure-util-perl
libfile-libmagic-perl
libipc-sharelite-perl
libmath-bigint-gmp-perl
libmath-tamuanova-perl
libopengl-xscreensaver-perl
libtext-hunspell-perl

And these are those that use Module::Install::XSUtil's cc_assert_lib() (which
in turn uses Devel::CheckLib):

libcrypt-dh-gmp-perl
libzeromq-perl

(note that, except libaudio-tagger-perl and libcrypt-dh-gmp-perl, all of them
embed Devel::CheckLib).

Now the question is, how do we fix them? We could patch them all to use
assert_lib() instead (so that the build would die()), and maybe patch the
embedded copies of Module::Install::XSUtil to use assert_lib() too.

Oh and there are also some packages that use "exit 0" directly such as
libxml-libxml-perl, though grepping for "exit 0" generates a lot of false
positives, since the Makefile.PL of a lot of packages ends in "exit 0;".

Cheers

-- 
perl -E '$_=q;$/= @{[@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20120807/c85257cb/attachment.pgp>