Bug#654899: libarchive-zip-perl: jh_manifest from javahelper creates corrupt archives (jars)

[gregor herrmann]

On Wed, 22 Feb 2012 17:35:28 +0200, Niko Tyni wrote:

> > Ah, the constant ZIP is used in the pre-ultimate BEGIN block in
> > t/common.pl. I could have seen this myself before when I threw
> > debug statements into the file ...
> > Is this run before HAVEZIP is defined? Somehow these multiple BEGIN
> > blocks confuse me. Or is it that it messes with something else?
> I see it now: the problem is that INPUTZIP is not created at all if
> /usr/bin/zip is not present, so the testZip() invocation from the last
> BEGIN {} block of t/common.pl fails.

Ah, so a different constant than what I guessed.
 
> As for the "last SKIP" thing, t/17_bug_73797.t is missing a SKIP: {}
> block around the last test. My fault, sorry.

Np.
 
> > Ok, building with unzip + zip packages ... and all tests (are run
> > and) pass!
> I suppose that's enough. As long as the test suite is working for
> us with the right build dependencies, we don't really have to iron out
> every last wrinkle. I probably won't in any case...

I agree, and I also don't plan to invest more time into this package
right now.

I've added a debian/TODO as a reminder just in case someone wants to
clean up t/common.pl; and: uploaded!


Cheers,
gregor
 
-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: The Who: My Generation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20120222/94795c4a/attachment.pgp>