Bug#710327: libapache2-mod-perl2: failing tests with Apache 2.4

[gregor herrmann]

On Tue, 04 Jun 2013 19:35:05 +0300, Niko Tyni wrote:

> > > Hm. I think that was actually the case earlier too and I just didn't
> > > notice it? At least the buildd logs seem that way.
> > I don't think I've seen it this way -- at least when I uploaded the
> > package it worked differently (and I would have noticed the failures
> > :))
> Hm. I see at least the kfreebsd-i386 buildd ran the ModPerl-Registry
> test suite twice. Clearly a separate manual run shouldn't be necessary.

Ack.
 
> > > > So this is a new patch (for 2x DefaultRuntimeDir) and some changes in
> > > > debian/rules.
> > > Wouldn't putting DefaultRuntimeDir into debian/apache2.conf suffice?
> > Good idea!
> > Unfortunately it doesn't work, seems like this doesn't get through?!
> Oh well. I suppose only known directives are picked up. Never mind,
> the Apache-Test approach is better.

Yup.
 
> > > Ideally, I think Apache-Test should be modified to add DefaultRuntimeDir
> > > into the base httpd.conf where it sets ServerRoot et al. I looked at
> > > that a bit but didn't get quite there yet.
> > Yup, works. No sure if this should be configurable, for now I've
> > just added it to the conf template as "@ServerRoot@/run".
> For reference, I'm attaching what I came up with. I put it
> inside an <IfVersion> block to make it easier to push upstream.

Nice.

Merged into the my previous attempt.
 
> It looks like logs is used for other similar things too (like
> the PID file) so I ditched the run directory. 

Make sense.
 
> The upstream httpd24 change of adding DefaultRuntimeDir to
> t/conf/extra.conf.in can be removed after this one is in.

Right; removed in the patch.
 
> Anyway, feel free to upload your solution (or anything else that
> works :) for now to fix the FTBFS bug. This is clearly going
> to take a while to converge.

Ok; uploaded.
And as usual: Thanks for your help!
 
> > Interestingly the same file also claims to create t/logs:
> >     $self->gendir($vars->{t_logs});
> > (line 1560). No idea why this doesn't happen (in time?).
> I suspect it's not called for the first t/TEST invocation that
> cleans the target. Or something like that.

Yeah, something like this.
 

Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Rolling Stones: Melody
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20130604/cae97d5c/attachment.pgp>