Bug#710983: [rt.cpan.org #59478] Re: Bug#710983: librdf-helper-perl: FTBFS with perl 5.18: test failures

[gregor herrmann]

On Mon, 03 Jun 2013 21:34:34 +0100, Dominic Hargreaves wrote:

> Source: librdf-helper-perl
> Version: 2.0-1
> Severity: important
> User: debian-perl at lists.debian.org
> Usertags: perl-5.18-transition
> Tags: sid jessie patch
> Forwarded: https://rt.cpan.org/Public/Bug/Display.html?id=72636
> 
> This package FTBFS with perl 5.18 from experimental (in a clean sbuild
> session):
> 
> syntax error at /build/dom-librdf-helper-perl_2.0-1-i386-8vMFqN/librdf-helper-perl-2.0/blib/lib/RDF/Helper/RDFRedland.pm line 133, near "$type qw( subject predicate object )"
> Global symbol "$type" requires explicit package name at /build/dom-librdf-helper-perl_2.0-1-i386-8vMFqN/librdf-helper-perl-2.0/blib/lib/RDF/Helper/RDFRedland.pm line 134.
> Global symbol "$self" requires explicit package name at /build/dom-librdf-helper-perl_2.0-1-i386-8vMFqN/librdf-helper-perl-2.0/blib/lib/RDF/Helper/RDFRedland.pm line 137.
> Global symbol "@nodes" requires explicit package name at /build/dom-librdf-helper-perl_2.0-1-i386-8vMFqN/librdf-helper-perl-2.0/blib/lib/RDF/Helper/RDFRedland.pm line 137.
> syntax error at /build/dom-librdf-helper-perl_2.0-1-i386-8vMFqN/librdf-helper-perl-2.0/blib/lib/RDF/Helper/RDFRedland.pm line 138, near "}"
> syntax error at /build/dom-librdf-helper-perl_2.0-1-i386-8vMFqN/librdf-helper-perl-2.0/blib/lib/RDF/Helper/RDFRedland.pm line 148, near "$type qw( subject predicate object )"
> Global symbol "$type" requires explicit package name at /build/dom-librdf-helper-perl_2.0-1-i386-8vMFqN/librdf-helper-perl-2.0/blib/lib/RDF/Helper/RDFRedland.pm line 149.
> Global symbol "@nodes" requires explicit package name at /build/dom-librdf-helper-perl_2.0-1-i386-8vMFqN/librdf-helper-perl-2.0/blib/lib/RDF/Helper/RDFRedland.pm line 152.
> syntax error at /build/dom-librdf-helper-perl_2.0-1-i386-8vMFqN/librdf-helper-perl-2.0/blib/lib/RDF/Helper/RDFRedland.pm line 154, near "}"
> syntax error at /build/dom-librdf-helper-perl_2.0-1-i386-8vMFqN/librdf-helper-perl-2.0/blib/lib/RDF/Helper/RDFRedland.pm line 192, near "}"
> /build/dom-librdf-helper-perl_2.0-1-i386-8vMFqN/librdf-helper-perl-2.0/blib/
> 
> ...
> 
> There is a possible fix on the RT ticket.

The patch is incomplete, I'm attaching a better one.

But the build still fails:

# prove --blib --verbose t/6_query_perl.t 
t/6_query_perl.t .. given is experimental at /tmp/buildd/librdf-helper-perl-2.0/blib/lib/RDF/Helper.pm line 28.
when is experimental at /tmp/buildd/librdf-helper-perl-2.0/blib/lib/RDF/Helper.pm line 29.
when is experimental at /tmp/buildd/librdf-helper-perl-2.0/blib/lib/RDF/Helper.pm line 30.

ok 1 - property hash contains key values
ok 2 - items hash key contains key values
Attribute (query) does not pass the type constraint because: Validation failed for 'RDF::Redland::Query' with value undef at reader RDF::Helper::RDFRedland::Query::query (defined at /tmp/buildd/librdf-helper-perl-2.0/blib/lib/RDF/Helper/RDFRedland/Query.pm line 13) line 15.
    RDF::Helper::RDFRedland::Query::query('RDF::Helper::RDFRedland::Query=HASH(0x2a8f948)') called at /usr/lib/perl5/Moose/Meta/Method/Delegation.pm line 92
    RDF::Helper::RDFRedland::Query::_execute('RDF::Helper::RDFRedland::Query=HASH(0x2a8f948)', 'RDF::Redland::Model=HASH(0x2969140)') called at /tmp/buildd/librdf-helper-perl-2.0/blib/lib/RDF/Helper/RDFRedland/Query.pm line 37
    RDF::Helper::RDFRedland::Query::execute('RDF::Helper::RDFRedland::Query=HASH(0x2a8f948)') called at /tmp/buildd/librdf-helper-perl-2.0/blib/lib/RDF/Helper/RDFRedland/Query.pm line 52
    RDF::Helper::RDFRedland::Query::selectrow_hashref('RDF::Helper::RDFRedland::Query=HASH(0x2a8f948)') called at t/6_query_perl.t line 105
    main::test('RDF::Helper=HASH(0x2823f18)') called at t/6_query_perl.t line 28
# Tests were run but no plan was declared and done_testing() was not seen.
Dubious, test returned 2 (wstat 512, 0x200)
All 2 subtests passed 

Test Summary Report
-------------------
t/6_query_perl.t (Wstat: 512 Tests: 2 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
Files=1, Tests=2,  1 wallclock secs ( 0.03 usr  0.00 sys +  0.50 cusr  0.01 csys =  0.54 CPU)
Result: FAIL


Cheers,
gregor
 

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Funny Van Dannen: Sozialismus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: qw-list.patch
Type: text/x-diff
Size: 2270 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20130605/c3ebc611/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20130605/c3ebc611/attachment.pgp>