Bug#808911: dh-make-perl: Switch from libdpkg-parse-perl to libdpkg-perl modules
Damyan Ivanov
dmn at debian.org
Sun Mar 27 08:02:00 UTC 2016
-=| gregor herrmann, 23.03.2016 17:21:59 +0100 |=-
> On Thu, 24 Dec 2015 12:07:06 +0100, Guillem Jover wrote:
>
> > On Mon, 2015-09-28 at 12:37:22 +0100, Andrew Beverley wrote:
> > > On Mon, 2015-09-28 at 13:12 +0200, Guillem Jover wrote:
>
> > > > What's the advantage of this over the various modules in libdpkg-perl?
> > >
> > > I think it's the only way to retrieve version information. It's a long time
> > > since I wrote my original patch for dh-make-perl, but I seem to remember
> > > that DPKG::Parse was the only module that provided certain information I
> > > needed (see
> > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=774074).
> > >
> > > I certainly tried to do it with other modules already packaged, but I
> > > couldn't gain all the required information.
> >
> > The attached untested patch should in principle do it. In any case the
> > available file is only ever up-to-date when using dselect, so this is
> > probably not a very generic solution. And if it's too slow, this should
> > be fixed in libdpkg-perl anyway as that would benefit every caller.
>
> Andy, Dam, what do you think about Guillem's patch?
Seems to work (tests pass), but is noticeably slower:
* without the patch
dh-make-perl-dev --cpan Catalyst 29,33s user 2,30s system 94% cpu
33,473 total
(second try, after one dummy to fill CPAN/dh-make-perl caches)
* with the patch
dh-make-perl-dev --cpan Catalyst 233,96s user 3,13s system 99% cpu
3:59,17 total
(both timings were on the gregoa/apt-file-3 branch)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20160327/027db676/attachment.sig>
More information about the pkg-perl-maintainers
mailing list