Bug#1046292: libx11-xcb-perl: Fails to build source after successful build

[Lucas Nussbaum]

Source: libx11-xcb-perl
Version: 0.19-1
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package libx11-xcb-perl
> dpkg-buildpackage: info: source version 0.19-1
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by gregor herrmann <gregoa at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean --no-parallel
>    dh_auto_clean -O--no-parallel
> 	make -j1 distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> rm -f \
>   XCB.bso XCB.def \
>   XCB.exp XCB.x \
>   XCB.bs blib/arch/auto/X11/XCB/extralibs.all \
>   blib/arch/auto/X11/XCB/extralibs.ld Makefile.aperl \
>   *.a *.o \
>   *perl.core MYMETA.json \
>   MYMETA.yml XCB.base \
>   XCB.bs XCB.bso \
>   XCB.c XCB.def \
>   XCB.exp XCB.o \
>   XCB_def.old blibdirs.ts \
>   core core.*perl.*.? \
>   core.[0-9] core.[0-9][0-9] \
>   core.[0-9][0-9][0-9] core.[0-9][0-9][0-9][0-9] \
>   core.[0-9][0-9][0-9][0-9][0-9] libXCB.def \
>   mon.out perl \
>   perl perl.exe \
>   perlmain.c pm_to_blib \
>   pm_to_blib.ts so_locations \
>   tmon.out 
> rm -rf \
>   XCB.o blib \
>   ppport.h 
> mv Makefile Makefile.old > /dev/null 2>&1
> rm -f \
>   Makefile Makefile.old \
>   XCB.o 
> rm -rf \
>   X11-XCB-0.19 
> "/usr/bin/perl" "-Iinc" "-MExtUtils::Manifest=fullcheck" -e fullcheck
> No such file: pm_to_blib
> No such file: ppport.h
> Not in MANIFEST: .pc/.quilt_patches
> Not in MANIFEST: .pc/.quilt_series
> Not in MANIFEST: .pc/.version
> Not in MANIFEST: .pc/applied-patches
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean -O--no-parallel
>    dh_clean -O--no-parallel
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building libx11-xcb-perl using existing ./libx11-xcb-perl_0.19.orig.tar.gz
> dpkg-source: warning: ignoring deletion of file ppport.h, use --include-removal to override
> dpkg-source: warning: ignoring deletion of file pm_to_blib, use --include-removal to override
> dpkg-source: info: local changes detected, the modified files are:
>  libx11-xcb-perl-0.19/XCB.inc
>  libx11-xcb-perl-0.19/XCB_xs.inc
>  libx11-xcb-perl-0.19/typedefs.h
>  libx11-xcb-perl-0.19/typemap
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/libx11-xcb-perl_0.19-1.diff.KCkJhj
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/libx11-xcb-perl_0.19-1_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.