Bug#1046333: libmodule-manifest-skip-perl: Fails to build source after successful build

[Lucas Nussbaum]

Source: libmodule-manifest-skip-perl
Version: 0.23-2
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package libmodule-manifest-skip-perl
> dpkg-buildpackage: info: source version 0.23-2
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by gregor herrmann <gregoa at debian.org>
>  dpkg-source --before-build .
>  fakeroot debian/rules clean
> CDBS WARNING:  copyright-check disabled - licensecheck is missing.
> test -x debian/rules
> rm -f debian/stamp-makefile-build debian/stamp-makefile-install
> /usr/bin/make -C . OPTIMIZE="-g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=2 -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include" LDDLFLAGS="-Wl,-z,relro -shared -L/usr/local/lib -fstack-protector-strong" -k clean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> true
> rm -f \
>   Skip.bso Skip.def \
>   Skip.exp Skip.x \
>    blib/arch/auto/Module/Manifest/Skip/extralibs.all \
>   blib/arch/auto/Module/Manifest/Skip/extralibs.ld Makefile.aperl \
>   *.a *.o \
>   *perl.core MYMETA.json \
>   MYMETA.yml blibdirs.ts \
>   core core.*perl.*.? \
>   core.[0-9] core.[0-9][0-9] \
>   core.[0-9][0-9][0-9] core.[0-9][0-9][0-9][0-9] \
>   core.[0-9][0-9][0-9][0-9][0-9] libSkip.def \
>   mon.out perl \
>   perl perl.exe \
>   perlmain.c pm_to_blib \
>   pm_to_blib.ts so_locations \
>   tmon.out 
> rm -rf \
>   blib 
> rm -f Makefile.old
> mv Makefile Makefile.old > /dev/null 2>&1
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
> rm -f debian/stamp-makefile-check
> rm -f debian/copyright_newhints
> rm -f debian/cdbs-install-list debian/cdbs-package-list debian/stamp-copyright-check
> rm -rf "debian/upstream-cruft"
> rm -f debian/stamp-upstream-cruft
> dh_clean 
> dh_clean: warning: Compatibility levels before 10 are deprecated (level 8 in use)
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building libmodule-manifest-skip-perl using existing ./libmodule-manifest-skip-perl_0.23.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  libmodule-manifest-skip-perl-0.23/Makefile.old
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/libmodule-manifest-skip-perl_0.23-2.diff.KXJIJk
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/libmodule-manifest-skip-perl_0.23-2_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.