Bug#1046973: libfile-inplace-perl: Fails to build source after successful build

[Lucas Nussbaum]

Source: libfile-inplace-perl
Version: 0.20-4
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> ----------------------------------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package libfile-inplace-perl
> dpkg-buildpackage: info: source version 0.20-4
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Jelmer Vernooij <jelmer at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean
>    dh_auto_clean
> 	make -j8 distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> "/usr/bin/perl" "-MExtUtils::Manifest=fullcheck" -e fullcheck
> rm -f \
>   Inplace.bso Inplace.def \
>   Inplace.exp Inplace.x \
>    blib/arch/auto/File/Inplace/extralibs.all \
>   blib/arch/auto/File/Inplace/extralibs.ld Makefile.aperl \
>   *.a *.o \
>   *perl.core MYMETA.json \
>   MYMETA.yml blibdirs.ts \
>   core core.*perl.*.? \
>   core.[0-9] core.[0-9][0-9] \
>   core.[0-9][0-9][0-9] core.[0-9][0-9][0-9][0-9] \
>   core.[0-9][0-9][0-9][0-9][0-9] libInplace.def \
>   mon.out perl \
>   perl perl.exe \
>   perlmain.c pm_to_blib \
>   pm_to_blib.ts so_locations \
>   tmon.out 
> rm -rf \
>   blib 
> mv Makefile Makefile.old > /dev/null 2>&1
> rm -f \
>   Makefile Makefile.old 
> rm -rf \
>   File-Inplace-0.20 
> Not in MANIFEST: .pc/.quilt_patches
> Not in MANIFEST: .pc/.quilt_series
> Not in MANIFEST: .pc/.version
> Not in MANIFEST: .pc/applied-patches
> Not in MANIFEST: .pc/fix-manpage-has-errors-from-pod2man.patch/lib/File/Inplace.pm
> Not in MANIFEST: debian/.debhelper/generated/libfile-inplace-perl/dh_installchangelogs.dch.trimmed
> Not in MANIFEST: debian/.debhelper/generated/libfile-inplace-perl/installed-by-dh_installdocs
> Not in MANIFEST: debian/.debhelper/generated/libfile-inplace-perl/installed-by-dh_installman
> Not in MANIFEST: debian/changelog
> Not in MANIFEST: debian/control
> Not in MANIFEST: debian/copyright
> Not in MANIFEST: debian/debhelper-build-stamp
> Not in MANIFEST: debian/files
> Not in MANIFEST: debian/libfile-inplace-perl.substvars
> Not in MANIFEST: debian/libfile-inplace-perl/DEBIAN/control
> Not in MANIFEST: debian/libfile-inplace-perl/DEBIAN/md5sums
> Not in MANIFEST: debian/libfile-inplace-perl/usr/share/doc/libfile-inplace-perl/changelog.Debian.gz
> Not in MANIFEST: debian/libfile-inplace-perl/usr/share/doc/libfile-inplace-perl/changelog.gz
> Not in MANIFEST: debian/libfile-inplace-perl/usr/share/doc/libfile-inplace-perl/copyright
> Not in MANIFEST: debian/libfile-inplace-perl/usr/share/man/man3/File::Inplace.3pm.gz
> Not in MANIFEST: debian/libfile-inplace-perl/usr/share/perl5/File/Inplace.pm
> Not in MANIFEST: debian/patches/fix-manpage-has-errors-from-pod2man.patch
> Not in MANIFEST: debian/patches/series
> Not in MANIFEST: debian/rules
> Not in MANIFEST: debian/source/format
> Not in MANIFEST: debian/watch
> Not in MANIFEST: t/test01.txt
> Not in MANIFEST: t/test02.txt
> Not in MANIFEST: t/test03.txt
> Not in MANIFEST: t/test04.txt
> Not in MANIFEST: t/test05.txt
> Not in MANIFEST: t/test06.txt
> Not in MANIFEST: t/test07.txt
> Not in MANIFEST: t/test08.txt
> Not in MANIFEST: t/test09.txt
> Not in MANIFEST: t/test10.txt
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building libfile-inplace-perl using existing ./libfile-inplace-perl_0.20.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: info: local changes detected, the modified files are:
>  libfile-inplace-perl-0.20/t/test01.txt
>  libfile-inplace-perl-0.20/t/test02.txt
>  libfile-inplace-perl-0.20/t/test03.txt
>  libfile-inplace-perl-0.20/t/test04.txt
>  libfile-inplace-perl-0.20/t/test05.txt
>  libfile-inplace-perl-0.20/t/test06.txt
>  libfile-inplace-perl-0.20/t/test07.txt
>  libfile-inplace-perl-0.20/t/test08.txt
>  libfile-inplace-perl-0.20/t/test09.txt
>  libfile-inplace-perl-0.20/t/test10.txt
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/libfile-inplace-perl_0.20-4.diff.Y5JjS2
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/libfile-inplace-perl_0.20-4_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.