<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<font face="monospace">Hi,<br>
<br>
Thanks for your review.<br>
<br>
</font><br>
<div class="moz-cite-prefix">在 2024/6/14 16:25, Paride Legovini 写道:<br>
</div>
<blockquote type="cite"
cite="mid:bee5954d-dd97-4668-b901-8792178740e5@debian.org">
<pre class="moz-quote-pre" wrap="">Hello,
I can review and sponsor imv 4.5.0-1, but I prefer to work on salsa
rather than on mentors. Some comments on the changes you pushed to
debian/latest:
(1) Past upstream imports were done via `gbp import-ref`, i.e. by adding
an upstream remote and importing the upstream tag. This has the
advantage of having the full upstream commit history in the packaging
repo, and this is why d/gbp.conf had `upstream-branch =`, which you
dropped in d8e53ea1.
Now the import of 4.5.0 is done and I'm not going to ask you to revert
an re-import via import-ref, however please revert d8e53ea1 to allow the
next imports to be done from a tag via import-ref.</pre>
</blockquote>
I do a test on my local, I check out to old version debian/4.4.0-1
to restart import,<br>
even <span style="white-space: pre-wrap">after drop </span><span
style="white-space: pre-wrap">`upstream-branch =` in </span><span
style="white-space: pre-wrap">d/gbp.conf,
we still can use </span><span style="white-space: pre-wrap">gbp import-ref -u4.5.0 to get </span><span
style="white-space: pre-wrap">the full upstream commit
history in the debian/latest branch.
I had push my test to:
<a class="moz-txt-link-freetext" href="https://salsa.debian.org/atzlinux-guest/imv/-/commits/debian/latest-has-upstream-commit-history/?ref_type=heads">https://salsa.debian.org/atzlinux-guest/imv/-/commits/debian/latest-has-upstream-commit-history/?ref_type=heads</a>
My test setting is:
git remote -v
atzlinux <a class="moz-txt-link-abbreviated" href="mailto:git@salsa.debian.org:atzlinux-guest/imv.git">git@salsa.debian.org:atzlinux-guest/imv.git</a> (fetch)
atzlinux <a class="moz-txt-link-abbreviated" href="mailto:git@salsa.debian.org:atzlinux-guest/imv.git">git@salsa.debian.org:atzlinux-guest/imv.git</a> (push)
upstream-imv <a class="moz-txt-link-freetext" href="https://git.sr.ht/~exec64/imv">https://git.sr.ht/~exec64/imv</a> (fetch)
upstream-imv <a class="moz-txt-link-freetext" href="https://git.sr.ht/~exec64/imv">https://git.sr.ht/~exec64/imv</a> (push)
There is a new version tag in remote upstream repo </span><span
style="white-space: pre-wrap">upstream-imv</span><span
style="white-space: pre-wrap">:
commit 8f36d35ff6a844de7d338a4e9b34bc98f114014b (tag: v4.5.0, upstream-imv/master)
run </span><span style="white-space: pre-wrap"></span><span
style="white-space: pre-wrap">"gbp import-ref -u4.5.0" will automate find this tag and import </span><span
style="white-space: pre-wrap">commit history.
so, </span><span style="white-space: pre-wrap">revert d8e53ea1 is not necessary.
</span>The gbp default <span style="white-space: pre-wrap">upstream-branch is upstream, this don't to interference use </span><span
style="white-space: pre-wrap"> </span><span
style="white-space: pre-wrap">gbp import-ref.</span><br>
<span style="white-space: pre-wrap"></span>
<blockquote type="cite"
cite="mid:bee5954d-dd97-4668-b901-8792178740e5@debian.org">
<pre class="moz-quote-pre" wrap="">
(2) The d/changelog style is not not very homogeneous. For example some
entries have the "d/somefile: " prefix, others do not. E.g.:
* d/u/metadata: remove obsolete fields: Contact, Name.
Already present in machine-readable debian/copyright.
* d/salsa-ci.yml: add salsa-ci file with the salsa pipeline
* d/control: bump Standards-Version: 4.7.0, no changes needed
^^^^^^^^^^^^^^^^^ note this
[...]
By all means: use the wording you prefer! Let's just try to keep things
homogeneous.</pre>
</blockquote>
I use routine-update package to help this new upstream version
packaging.<br>
Some of these changelog style is generated by routine-update.<br>
I had updated the changelog in my repo.<br>
<br>
<blockquote type="cite"
cite="mid:bee5954d-dd97-4668-b901-8792178740e5@debian.org">
<pre class="moz-quote-pre" wrap="">
(3) You added d/salsa-ci.yml, but it didn't trigger as that's not the
default location for CI files. I now configured the project to look for
the file in that location, so it *should* trigger with the next push.</pre>
</blockquote>
Good!<br>
I'm only the Developer role in debian-phototools-team salsa group, <br>
I has not right to setting CI.<br>
BTW: <span style="white-space: pre-wrap">d/salsa-ci.yml is automate create by </span>routine-update,
I don't modify.<br>
<br>
<blockquote type="cite"
cite="mid:bee5954d-dd97-4668-b901-8792178740e5@debian.org">
<pre class="moz-quote-pre" wrap="">
I didn't try to build imv, I'll wait for a CI run first. We may have to
adjust something to fix some jobs, or we may want to disable some.
(4) In the future please submit your changes for review in a salsa MR,
or at least in a separate branch, so to keep the debian/latest history
cleaner. This is also valid for the changes I suggested above: ideally
they should come in a MR, especially now that we're going to have CI.
I may configure the project to restrict direct pushes to debian/latest.</pre>
</blockquote>
Ok, I'll use MR next.<br>
<br>
Please help view:<br>
<a class="moz-txt-link-freetext" href="https://salsa.debian.org/debian-phototools-team/imv/-/merge_requests/5/">https://salsa.debian.org/debian-phototools-team/imv/-/merge_requests/5/</a><br>
<blockquote type="cite"
cite="mid:bee5954d-dd97-4668-b901-8792178740e5@debian.org">
<pre class="moz-quote-pre" wrap="">
Thanks for working at imv!
Paride
On 2024-06-14 05:46, xiao sheng wen(肖盛文) wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Package: sponsorship-requests
Severity: normal
Dear mentors,
I am looking for a sponsor for my package "imv":
* Package name : imv
Version : 4.5.0-1
Upstream contact : Harry Jeffery <a class="moz-txt-link-rfc2396E" href="mailto:harry@exec64.co.uk"><harry@exec64.co.uk></a>
* URL : <a class="moz-txt-link-freetext" href="https://sr.ht/~exec64/imv">https://sr.ht/~exec64/imv</a>
* License : Expat
* Vcs : <a class="moz-txt-link-freetext" href="https://salsa.debian.org/debian-phototools-team/imv">https://salsa.debian.org/debian-phototools-team/imv</a>
Section : graphics
The source builds the following binary packages:
imv - X11/Wayland image viewer intended for use with tiling window managers
To access further information about this package, please visit the
following URL:
<a class="moz-txt-link-freetext" href="https://mentors.debian.net/package/imv/">https://mentors.debian.net/package/imv/</a>
Alternatively, you can download the package with 'dget' using this command:
dget -x <a class="moz-txt-link-freetext" href="https://mentors.debian.net/debian/pool/main/i/imv/imv_4.5.0-1.dsc">https://mentors.debian.net/debian/pool/main/i/imv/imv_4.5.0-1.dsc</a>
Changes since the last upload:
imv (4.5.0-1) unstable; urgency=medium
.
* Team upload.
* New upstream version
* Add salsa-ci file (routine-update)
* Remove obsolete fields Contact, Name from debian/upstream/metadata
(already
present in machine-readable debian/copyright).
* Bump Standards-Version: 4.7.0
* d/copyright: update year info to 2024
* d/control:
- Build-Depends add libturbojpeg0-dev
- Build-Depends add libjxl-dev, enable libjxl Backends
* d/gbp.conf: update to use default upstream-branch
Regards,
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
</blockquote>
Regards,<br>
<pre class="moz-signature" cols="72">--
肖盛文 xiao sheng wen
<a class="moz-txt-link-freetext" href="https://www.atzlinux.com">https://www.atzlinux.com</a> 《铜豌豆 Linux》基于 Debian 的 Linux 中文 桌面 操作系统
Debian QA page: <a class="moz-txt-link-freetext" href="https://qa.debian.org/developer.php?login=atzlinux%40sina.com">https://qa.debian.org/developer.php?login=atzlinux%40sina.com</a>
Debian salsa: <a class="moz-txt-link-freetext" href="https://salsa.debian.org/atzlinux-guest">https://salsa.debian.org/atzlinux-guest</a>
GnuPG Public Key: 0x00186602339240CB</pre>
</body>
</html>