[pkg-php-pear] Let's reconsider the way Symfony2 Components are packaged for Debian

[Daniel Beyer]

Hi,

first of all: Sorry I was that unresponsive. I was very busy and could
not take out that much time for Debian as I wished to. Things should get
better in August and especially in September.

Please find my replies inline...

On Thu, 2014-07-10 at 12:57 -0400, David Prévot wrote:
> Hi,
> 
> (...)
> 
> I’ve just pushed a few minor fixes. Once you’re done, you may ask for a
> complete review on debian-l10n-english at l.d.o where people will be happy
> to help.
> 

Thanks for your changes and the hint to the debian-l10n-english list.
Now that all the components, bridges and bundles are in d/control, I
think it's worth asking for a review there.


> About the control file, you may wish to provide per-package Homepage: I
> find it pretty handy to be pointed directly to
> <http://symfony.com/doc/current/components/class_loader/introduction.htm> by
> “apt-cache show php-symfony-classloader” rather than have to find it by
> myself from <http://symfony.com>.
> 

I added individual Homepage: fields for all the components, pointing (in
case of the class loader) to:
<http://symfony.com/components/ClassLoader>


> You may also fill in the Replaces, Breaks, Provides field as suggested
> in /usr/share/doc/pkg-php-tools/README.Composer: even if they’re
> probably useless right now, they may become useful in a later symfony
> package version.
> 

Done.


> I’ve only reviewed the Component/[BC]* upstream parts so far, but
> noticed that hiddeninput.exe is back in Git.
> 

That was my fault. It happened during the update to 2.3.17. I followed
my own instruction in README.source and the outcome was the non-repacked
source was used. I corrected the instructions and removed
hiddeninput.exe, again.
BTW.: Thanks for your updates to d/watch and d/README.source. Importing
a new upstream version now works like a charm (tested with 2.3.18).


> The d/copyright is also incomplete, see e.g., the output of the
> following command (on one line, probably broken by my MUA):
> 
> $ git grep -i '\(copyr\|licen\)'|grep -v '"license": "MIT"'|grep -v ' *
> For the full copyright and license information, please view the
> LICENSE'|grep -v 'AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
> DAMAGES OR OTHER'|grep -v 'The above copyright notice and this
> permission notice shall be included in all'|grep -v 'to use, copy,
> modify, merge, publish, distribute, sublicense, and/or sell'|grep -v
> 'Copyright (c) 2004-2014 Fabien Potencier'
> 

Dealing with the licensing will be one of the next things, I guess.
Thanks for the command. It is a great help.


> I haven’t yet tested to build it, but the d/rules looks promising,
> thanks for your work on this non-trivial packaging! You may push the
> workaround for bug #754150 in a simple patch to make it a bit simpler
> until it gets fixed.
> 

I rather would like to see bug #754150 closed and get rid of the
workaround. I attached patches to bts, that can be applied to the repo
of pkg-php-tools. How are chances a new version of pkg-php-tools hits
sid any time soon?


The next two things I plan to work on are:
* Updating the wiki page [1], since there are some Suggests: and even (I
think) some Depends: that are not found in Debian and are not yet
mentioned there.
* Check the licensing of source.

Of course any help on the packaging is always very welcome.


Daniel.

[1] https://wiki.debian.org/PHP/SymfonyComponents

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-php-pear/attachments/20140803/da83931d/attachment.sig>