[pkg-php-pear] Sponsor for php-swiftmailer

[Nicolas]

Hi David,

Le lun. 2 mars 2020 à 12:30, David Prévot <david at tilapin.org> a écrit :

>
> I doubt you tested your package,


I tested it but not enough. :-(


> it can’t even be uninstalled. You
> should at least use debian/pkg-php-tools-overrides to set the
> appropriate php-email-validator package name, drop the
> php-symfony-polyfill* one(s), and set the proper dependency instead. You
> may also need to loud your dependencies.
>
> I also looked quickly at debian/ before building the package, and there
> is also some cleanup needed IMHO:
> - please, run the upstream test suite (at build time and in CI),
> - you probably should install the doc rather than the tests in u/s/d,
> - MIT should probably be Expat (d/copyright),
> - debian/dirs seems useless,
> - transitional package seems unneeded since at least Jessie;
> - reference to a pkg-php-tools version satisfied since even before that.
> - what is the point of “Depends: php-cli”?
> - ditto for “Suggests: libapache2-mod-php | php”?
> - UNRELEASED is not a suitable version (d/changelog).
>
> I haven’t looked at the upstream part yet.
>
>
Thanks for taking time to review my packaging. I will work on it.

Regards,
Nicolas


> Regards
>
> _______________________________________________
> pkg-php-pear mailing list
> pkg-php-pear at alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-php-pear
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20200302/138d55a0/attachment.html>