[pkg-php-pear] Sponsor for php-swiftmailer

Robin Gustafsson robin at rgson.se
Sat Sep 26 23:20:01 BST 2020


Hi team,

Please review and sponsor php-swiftmailer [1].

Issues mentioned in previous review comments have been fixed.
>From David Prévot:
> I doubt you tested your package, it can’t even be uninstalled. You
> should at least use debian/pkg-php-tools-overrides to set the
> appropriate php-email-validator package name, drop the
> php-symfony-polyfill* one(s), and set the proper dependency instead. You
> may also need to loud your dependencies.
>
> I also looked quickly at debian/ before building the package, and there
> is also some cleanup needed IMHO:
> - please, run the upstream test suite (at build time and in CI),
> - you probably should install the doc rather than the tests in u/s/d,
> - MIT should probably be Expat (d/copyright),
> - debian/dirs seems useless,
> - transitional package seems unneeded since at least Jessie;
> - reference to a pkg-php-tools version satisfied since even before that.
> - what is the point of “Depends: php-cli”?
> - ditto for “Suggests: libapache2-mod-php | php”?
> - UNRELEASED is not a suitable version (d/changelog).
>From myself:
> debian/control doesn't mention the team in Maintainer nor Uploaders.

I have also added an autoload.php file to close the last remaining bug.

Thank you for your time.

[1]: https://salsa.debian.org/php-team/pear/php-swiftmailer

Regards,
Robin



More information about the pkg-php-pear mailing list