<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hello,<br>
</p>
<div class="moz-cite-prefix">Le 16/07/2022 à 08:14, David Prévot a
écrit :<br>
</div>
<blockquote type="cite"
cite="mid:6f898a03-ac97-e234-b52f-41dcf38d3157@tilapin.org">I just
had a quick look at php-kissifrot-php-ixr.
<br>
</blockquote>
Thanks.<br>
<blockquote type="cite"
cite="mid:6f898a03-ac97-e234-b52f-41dcf38d3157@tilapin.org">
d/copyright:
<br>
- Upstream-Contact is useless as is.
<br>
- You could simplify it with just one entry for upstream.
<br>
</blockquote>
Changed.<br>
<blockquote type="cite"
cite="mid:6f898a03-ac97-e234-b52f-41dcf38d3157@tilapin.org">d/control:
<br>
- Build-Depends: pkg-php-tools is still not needed (actually you
<br>
don’t even need to use phpabtpl(1) to provide a template since
<br>
composer.json has nothing in "require" except php).
<br>
- Description: it should provide meaningful information about
the
<br>
package (currently, there isn’t).
<br>
- Standards-Version: you don’t need the fourth component (minor
patch
<br>
level) and again, a new one is available.
<br>
</blockquote>
See [1] below.<br>
<blockquote type="cite"
cite="mid:6f898a03-ac97-e234-b52f-41dcf38d3157@tilapin.org">d/rules:
The phpab(1) call is the only needed line (without template).
<br>
</blockquote>
See [1] below.
<blockquote type="cite"
cite="mid:6f898a03-ac97-e234-b52f-41dcf38d3157@tilapin.org">d/clean:
Only one line seems relevant.
<br>
</blockquote>
See [1] below.
<blockquote type="cite"
cite="mid:6f898a03-ac97-e234-b52f-41dcf38d3157@tilapin.org">
d/install:
<br>
- /usr/share/php/IXR should be the correct install path to match
<br>
upstream namespace.
<br>
</blockquote>
Changed.<br>
<blockquote type="cite"
cite="mid:6f898a03-ac97-e234-b52f-41dcf38d3157@tilapin.org"> -
/usr/share/pkg-php-tools/autoloaders/php-kissifrot-php-ixr should
be
<br>
provided so that phpabtpl(1) provides the accurate
autoload.php path
<br>
to dependencies.
<br>
</blockquote>
Changed.<br>
<blockquote type="cite"
cite="mid:6f898a03-ac97-e234-b52f-41dcf38d3157@tilapin.org">
d/watch, d/gbp.conf: Upstream provides no .gitattibutes, no test
(I doubt the project made for “more recent systems (PHP 5.4+
ones)” will provide any soon, but
<a class="moz-txt-link-freetext" href="https://github.com/kissifrot/php-ixr/pull/5">https://github.com/kissifrot/php-ixr/pull/5</a> makes me think I could
be wrong), so could use directly the upstream tarball.
<br>
</blockquote>
<p>See [1] below.</p>
<p><br>
</p>
<p>[1]: What about continuing to use the source from the git repo? I
initially used the tarball and then changed all the packages to
fit the <a class="moz-txt-link-freetext" href="https://wiki.debian.org/Teams/DebianPHPGroup/Composer">https://wiki.debian.org/Teams/DebianPHPGroup/Composer</a>
guidelines which suggests to use the git repo as source. I would
prefer to leave it that way which would prevent from having to do
the change again later on if needed.</p>
<p>I have the same opinion on the cleanup of d/rules, d/cleanup,
phpabtpl. IMHO it doesn't harm that way, and would ease any future
update of the package if it uses more features of composer.json or
adds tests.<br>
</p>
<p>The other changes are committed. Waiting for your comments.<br>
</p>
<p><br>
</p>
<p>Cheers</p>
<p>Fab<br>
</p>
<div id="grammalecte_menu_main_button_shadow_host" style="width:
0px; height: 0px;"></div>
</body>
</html>