[Pkg-privacy-maintainers] Bug#1066313: torsocks: FTBFS: config-file.c:184:23: error: implicit declaration of function ‘conf_file_set_enable_ipv6’ [-Werror=implicit-function-declaration]

Lucas Nussbaum lucas at debian.org
Wed Mar 13 11:45:58 GMT 2024 

Source: torsocks
Version: 2.4.0-1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> /bin/bash ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I../.. -I../.. -I../../src -I../../include -include config.h  -I../../include -I../../src -Wdate-time -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -fPIE -fwrapv --param ssp-buffer-size=1 -fstack-protector-all -c -o onion.lo onion.c
> libtool: compile:  gcc -DHAVE_CONFIG_H -I../.. -I../.. -I../../src -I../../include -include config.h -I../../include -I../../src -Wdate-time -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -fwrapv --param ssp-buffer-size=1 -fstack-protector-all -c utils.c  -fPIC -DPIC -o .libs/utils.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I../.. -I../.. -I../../src -I../../include -include config.h -I../../include -I../../src -Wdate-time -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -fwrapv --param ssp-buffer-size=1 -fstack-protector-all -c onion.c  -fPIC -DPIC -o .libs/onion.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I../.. -I../.. -I../../src -I../../include -include config.h -I../../include -I../../src -Wdate-time -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -fwrapv --param ssp-buffer-size=1 -fstack-protector-all -c log.c  -fPIC -DPIC -o .libs/log.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I../.. -I../.. -I../../src -I../../include -include config.h -I../../include -I../../src -Wdate-time -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -fwrapv --param ssp-buffer-size=1 -fstack-protector-all -c connection.c  -fPIC -DPIC -o .libs/connection.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I../.. -I../.. -I../../src -I../../include -include config.h -I../../include -I../../src -Wdate-time -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -fwrapv --param ssp-buffer-size=1 -fstack-protector-all -c compat.c  -fPIC -DPIC -o .libs/compat.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I../.. -I../.. -I../../src -I../../include -include config.h -I../../include -I../../src -Wdate-time -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -fwrapv --param ssp-buffer-size=1 -fstack-protector-all -c socks5.c  -fPIC -DPIC -o .libs/socks5.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I../.. -I../.. -I../../src -I../../include -include config.h -I../../include -I../../src -Wdate-time -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -fwrapv --param ssp-buffer-size=1 -fstack-protector-all -c config-file.c  -fPIC -DPIC -o .libs/config-file.o
> libtool: compile:  gcc -DHAVE_CONFIG_H -I../.. -I../.. -I../../src -I../../include -include config.h -I../../include -I../../src -Wdate-time -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -fwrapv --param ssp-buffer-size=1 -fstack-protector-all -c log.c -fPIE -o log.o >/dev/null 2>&1
> libtool: compile:  gcc -DHAVE_CONFIG_H -I../.. -I../.. -I../../src -I../../include -include config.h -I../../include -I../../src -Wdate-time -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -fwrapv --param ssp-buffer-size=1 -fstack-protector-all -c compat.c -fPIE -o compat.o >/dev/null 2>&1
> config-file.c: In function ‘parse_config_line’:
> config-file.c:184:23: error: implicit declaration of function ‘conf_file_set_enable_ipv6’ [-Werror=implicit-function-declaration]
>   184 |                 ret = conf_file_set_enable_ipv6(tokens[1], config);
>       |                       ^~~~~~~~~~~~~~~~~~~~~~~~~
> config-file.c: In function ‘conf_file_set_socks5_user’:
> config-file.c:332:9: warning: ‘__builtin_strncpy’ output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
>   332 |         strncpy(config->conf_file.socks5_username, username, strlen(username));
>       |         ^
> config-file.c:325:13: note: length computed here
>   325 |         if (strlen(username) > sizeof(config->conf_file.socks5_username)) {
>       |             ^~~~~~~~~~~~~~~~
> config-file.c: In function ‘conf_file_set_socks5_pass’:
> config-file.c:364:9: warning: ‘__builtin_strncpy’ output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
>   364 |         strncpy(config->conf_file.socks5_password, password, strlen(password));
>       |         ^
> config-file.c:357:13: note: length computed here
>   357 |         if (strlen(password) > sizeof(config->conf_file.socks5_password)) {
>       |             ^~~~~~~~~~~~~~~~
> libtool: compile:  gcc -DHAVE_CONFIG_H -I../.. -I../.. -I../../src -I../../include -include config.h -I../../include -I../../src -Wdate-time -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -fwrapv --param ssp-buffer-size=1 -fstack-protector-all -c utils.c -fPIE -o utils.o >/dev/null 2>&1
> libtool: compile:  gcc -DHAVE_CONFIG_H -I../.. -I../.. -I../../src -I../../include -include config.h -I../../include -I../../src -Wdate-time -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -fwrapv --param ssp-buffer-size=1 -fstack-protector-all -c onion.c -fPIE -o onion.o >/dev/null 2>&1
> libtool: compile:  gcc -DHAVE_CONFIG_H -I../.. -I../.. -I../../src -I../../include -include config.h -I../../include -I../../src -Wdate-time -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -fwrapv --param ssp-buffer-size=1 -fstack-protector-all -c connection.c -fPIE -o connection.o >/dev/null 2>&1
> cc1: some warnings being treated as errors
> make[3]: *** [Makefile:404: config-file.lo] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/torsocks_2.4.0-1_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

More information about the Pkg-privacy-maintainers mailing list