[From nobody Fri Jul 10 17:51:06 2026
Received: (at submit) by bugs.debian.org; 11 Jun 2026 18:47:15 +0000
X-Spam-Checker-Version: SpamAssassin 4.0.1-bugs.debian.org_2005_01_02
 (2024-03-25) on buxtehude.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-9.9 required=4.0 tests=BAYES_00, FOURLA,
 FROMDEVELOPER, 
 NO_RELAYS,XMAILER_REPORTBUG autolearn=ham autolearn_force=no
 version=4.0.1-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 20; hammy, 122; neutral, 33; spammy,
 2. spammytokens:0.941-+--H*r:bugs.debian.org, 0.935-+--receive
 hammytokens:0.000-+--H*F:U*carnil, 0.000-+--XDebbugsCc,
 0.000-+--X-Debbugs-Cc, 0.000-+--HTo:N*Debian, 0.000-+--H*Ad:N*Bug
Return-path: <carnil@debian.org>
Received: via submission by buxtehude.debian.org with esmtp (Exim 4.96)
 (envelope-from <carnil@debian.org>) id 1wXkQt-001B86-0w
 for submit@bugs.debian.org; Thu, 11 Jun 2026 18:47:15 +0000
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Salvatore Bonaccorso <carnil@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: onionshare: OnionShare Receive mode writes uploaded files even when
 file uploads are disabled
Message-ID: <178120362743.3409805.969696746002628510.reportbug@eldamar.lan>
X-Mailer: reportbug 13.2.0
Date: Thu, 11 Jun 2026 20:47:07 +0200
Delivered-To: submit@bugs.debian.org

Source: onionshare
Version: 2.6.3-3
Severity: important
Tags: security upstream
X-Debbugs-Cc: carnil@debian.org, Debian Security Team <team@security.debian.org>

Hi

https://github.com/onionshare/onionshare/security/advisories/GHSA-v833-3823-cmhp

> OnionShare CLI/Desktop 2.6.3 does not enforce the Receive mode
> disable_files setting at the file upload sink. When a Receive service
> is configured as a text-message-only endpoint (--disable-files /
> "Disable uploading files"), a remote sender who can reach the
> OnionShare service can still send a crafted multipart request
> containing file[]; OnionShare writes the uploaded bytes to disk before
> the route handler skips file accounting.
> 
> This affects the shipped onionshare-cli Python package and the desktop
> application because both use the same onionshare_cli.web.receive_mode
> request-streaming implementation.

Regards,
Salvatore
]