[ProFTP] Build modules equally

Francesco P. Lovergine frankie at debian.org
Mon Apr 30 20:08:35 BST 2018


On Mon, Apr 30, 2018 at 01:24:41PM +0200, Hilmar Preuße wrote:
>Hi,
>
>the upstream .orig.tar.gz files of most modules look equally. Hence I'd
>expect that they are built equally. I'd expect that the files in debian/
>only differ in the module name and the package description. I think
>about a package template, which should make it easy to package more
>proftp modules for Debian.
>
>I started comparing proftpd-mod-autohost and proftpd-mod-case (these are
>already on salsa) and found more differences than expected. Work is
>ongoing to kill them. Two questions I can't answer:
>
>1.
>The watch file of case reads:
>https://github.com/Castaglia/proftpd-mod_case/ (.*).tar.gz
>
>The watch file of autohost reads:
>http://www.castaglia.org/proftpd/modules/proftpd-mod-autohost-([\d\.]+)\.tar\.gz
>
>I'd then use the one from autohost...or the one from vroot? This one is
>at least verified to work as there are released files.
>
>opts=filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/proftpd-mod_vroot-$1\.tar\.gz/
>\
>  https://github.com/Castaglia/proftpd-mod_vroot/tags .*/v?(\d\S*)\.tar\.gz
>

Currently we should be able to use the same pattern for most of the modules,
because TJ uses github for all of them.

>
>2. Most module package build only a single package. Therefore I'd expect
>that most files in debian/ (dirs, docs, etc.) are not named like the
>binary package.
>
>example:
>hille at sid:~/devel/proftp/aaa_git/proftpd-mod-autohost/debian $ ls -l
>proftpd-mod-autohost.*
>-rw-r--r-- 1 hille users  44 Apr 28 17:08 proftpd-mod-autohost.dirs
>-rw-r--r-- 1 hille users 320 Apr 28 17:08 proftpd-mod-autohost.doc-base
>-rw-r--r-- 1 hille users  67 Apr 28 17:08 proftpd-mod-autohost.install
>-rw-r--r-- 1 hille users  91 Apr 28 17:08 proftpd-mod-autohost.links
>
>Any specific reason why the long names were used, instead of the short
>names?
>

Different modules had different autorships historically and that justifies
the changes, among with different options used in dh_make (and different
versions used).

-- 
Francesco P. Lovergine



More information about the Pkg-proftpd-maintainers mailing list