Hi Andreas,

I need a second pair of eyes for this...

On  Mi 25 Jul 2018 01:55:09 CEST, Andreas Beckmann wrote:

> Package: x2goserver
> Version: 4.1.0.0-4
> Severity: serious
> User: debian-qa@lists.debian.org
> Usertags: piuparts
>
> Hi,
>
> during a test with piuparts I noticed your package succeeded to install,
> but thereafter failed to reinstall the same version over it again.
>
> Like a plain failure on initial install this makes the package too buggy
> for a release, thus the severity.
>
> From the attached log (scroll to the bottom...):
>
> 2m3.2s DEBUG: Starting command: ['chroot',  
> '/srv/piuparts/tmp/tmpijsFHK', 'apt-get', '-y', 'install',  
> '--reinstall', 'x2goserver=4.1.0.0-4']
> 2m4.3s DUMP:
>   Reading package lists...
>   Building dependency tree...
>   Reading state information...
>   debconf: delaying package configuration, since apt-utils is not installed
>   0 upgraded, 0 newly installed, 1 reinstalled, 0 to remove and 0  
> not upgraded.
>   Need to get 0 B/107 kB of archives.
>   After this operation, 0 B of additional disk space will be used.
>   (Reading database ...
> (Reading database ... 8797 files and directories currently installed.)
>   Preparing to unpack .../x2goserver_4.1.0.0-4_amd64.deb ...
>   Unpacking x2goserver (4.1.0.0-4) over (4.1.0.0-4) ...
>   Setting up x2goserver (4.1.0.0-4) ...
>   ln: failed to create symbolic link '/etc/x2go/applications': File exists
>   dpkg: error processing package x2goserver (--configure):
>    installed x2goserver package post-installation script subprocess  
> returned error exit status 1
>   Errors were encountered while processing:
>    x2goserver
>   E: Sub-process /usr/bin/dpkg returned an error code (1)
> 2m4.3s ERROR: Command failed (status=100): ['chroot',  
> '/srv/piuparts/tmp/tmpijsFHK', 'apt-get', '-y', 'install',  
> '--reinstall', 'x2goserver=4.1.0.0-4']
>
>
> cheers,
>
> Andreas

The only "ln -s" comand in postscript is this:

```
                 # create /etc/x2go/applications symlink if not  
already there (as link or as dir)
                 if ! test -e /etc/x2go/applications; then
                         ln -s /usr/share/applications /etc/x2go/applications
                 fi
```

(see  
https://salsa.debian.org/debian-remote-team/x2goserver/blob/master/debian/x2goserver.postinst#L56)

To my understanding, the code checks if /etc/x2go/applications exists,  
and only if not, it creates the symlink.

Note that the symlink can also be dropped by the site admin and  
replaced by a folder with copied .desktop files.

I don't really understand why piuparts fires here...

Any idea?
Mike
-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

