[Pkg-roundcube-maintainers] Bug#619411: roundcube-core: program/include/iniset.php should not alter INSTALL_PATH constant

[Vincent Bernat]

OoO  En cette matinée  ensoleillée du  jeudi 24  mars 2011,  vers 09:47,
Teodor MICU <mteodor at gmail.com> disait :

>>> I'm using roundcube with the upstream 'iniset.php' with no problems.
>> 
>> SCRIPT_FILENAME may be  set by a lot of components. It  is set by Apache
>> if you use  mod_php, set by PHP if  you use FPM, etc. I did  not find an
>> authoritative  source if  SCRIPT_FILENAME  should or  should not  follow
>> symlinks. I don't remember why we  created this patch but I suppose this
>> was a useful once.

> Look, this is quite simple. Roundcube upstream is using it and Debian
> has modified it to a hardcoded value that is not necessary. I've
> proven that it works either way.

Upstream does not use symlinks.  You have only proven that removing your
patch works in your case. SCRIPT_FILENAME variable may be set by various
softwares. As I said, if you  use mod_php, this is Apache that sets this
variable. If  you use PHP FPM, this  is PHP that sets  this variable. If
you   use  lighttpd   fastcgi,  this   is  lighttpd   which   sets  this
variable. Each of those may  set SCRIPT_FILENAME differently and some of
them may follow symlinks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-roundcube-maintainers/attachments/20110324/679f9728/attachment.pgp>