[DRE-maint] Bug#856606: gitlab: fails to upgrade from 'stretch': nginx example configuration file not found

[Andreas Beckmann]

On 2017-03-09 10:27, Pirate Praveen wrote:
>> Having briefly looked at the postinst script, it appears to me that all
>> the nginx_* variables are not set at all ...
> 
> nginx_* variables are set in gitlab-debian.conf. Since this version of
> gitlab makes a change in those variables postinst should be looking at
> new locations, but ucf seems to be not installing the new version of
> config file.
> 
> These variables are set in line 45 of postinst. I tried moving ucf
> registration code before this line, but the result is same.

I checked for sourcing (.) other configs, didn't notice the
  export $(cat ...)

to make the error message more useful:
echo "nginx example configuration file ${nginx_conf_example} not found"

I think the problem is the paths to the templates being set in config
files. You load the existing config file, which contains paths from the
previous package version, but these files no longer exist.
nginx_conf_example (and all other similar variables) must be set in the
postinst itself (which should be the only user of them), they are not
user^Wadmin-configurable.


Andreas