[DRE-maint] Bug#962259: ruby-rqrcode 1.1.2-3 breaks 2FA settings page

[Maximilian Stein]

Hi,

I actually found the culprit — it's actually ruby-rqrcode. Downgrading 
to 0.4.2-3 fixed the issue of the 2FA page.

I also found this in my logs:

Started GET "/-/profile/two_factor_auth" for 10.32.5.1 at 2021-02-22 
17:25:44 +0100
Processing by Profiles::TwoFactorAuthsController#show as HTML
Completed 500 Internal Server Error in 368ms (ActiveRecord: 14.7ms | 
Elasticsearch: 0.0ms | Allocations: 89772)

NoMethodError (undefined method `module_count' for 
#<RQRCode::QRCode:0x0000558a5ee3c6d0>
Did you mean?  modules):

app/controllers/profiles/two_factor_auths_controller.rb:134:in 
`build_qr_code'
app/controllers/profiles/two_factor_auths_controller.rb:39:in `show'
app/controllers/application_controller.rb:499:in `set_current_admin'
lib/gitlab/session.rb:11:in `with_session'


So, apparently, the newer ruby-rqrcode version breaks the 2FA settings page.

Best,
Maximilian



-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-ruby-extras-maintainers/attachments/20210222/9594ee86/attachment.sig>