[DRE-maint] Bug#1031548: FTBFS with ruby-jekyll-github-metadata 2.15.0

[Daniel Leidert]

Am Sonntag, dem 26.02.2023 um 16:57 +0200 schrieb Adrian Bunk:
> On Sun, Feb 26, 2023 at 03:47:49PM +0100, Daniel Leidert wrote:
> > Am Samstag, dem 25.02.2023 um 16:15 +0200 schrieb Adrian Bunk:
> > 
> > [..]
> > > FYI:
> > > 
> > > The package in bookworm builds with jekyll-github-metadata
> > > 2.15.0:
> > > https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/ruby-jekyll-remote-theme.html
> > > (the buildinfo link has the complete package list)
> > 
> > That is due to this environments not running the failing test. The
> > test-file checks if there is an internet connection and adds or
> > removes
> > tests depending on the outcome). The test in question is one that
> > requires an internet connection.
> > ...
> 
> Accessing the internet during the build is an RC bug.

It would be pretty stupid to generally disable tests for a *remote
theme* plugin (or any other package) that by defition relies on the
internet. This would disable the majority of tests here. We (as in "the
Ruby team") instead handle the tests if there is no internet, and
whenever possible, run them via autopkgtest (needs-internet
restriction) at least.

IMHO this is a valid approach and in this case spotted a regression. To
my understanding, builds must not fail due to access attempts and the
build itself must not rely on downloaded resources. However, this is
the test stage, not the build stage. But if you feel that strongly
about that, please show me the exact ruling. It won't change the fact
though, that this package will fail autopkgtest anyway due to a
regression.


Daniel