[DRE-maint] Bug#1042132: ruby-gnome: FTBFS: rbglib_bookmarkfile.c:39:1: error: static declaration of ‘g_bookmark_file_get_type’ follows non-static declaration

[Lucas Nussbaum]

Source: ruby-gnome
Version: 3.4.3-2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20230726 ftbfs-trixie

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> x86_64-linux-gnu-gcc -I. -I/usr/include/x86_64-linux-gnu/ruby-3.1.0 -I/usr/include/ruby-3.1.0/ruby/backward -I/usr/include/ruby-3.1.0 -I. -I/<<PKGBUILDDIR>>/debian/tmp/usr/lib/x86_64-linux-gnu/ruby/vendor_ruby/3.1.0  -I/usr/lib/x86_64-linux-gnu/ruby/vendor_ruby/3.1.0  -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -DHAVE_UNISTD_H -DHAVE_G_SPAWN_CLOSE_PID -DHAVE_G_THREAD_INIT -DHAVE_G_MAIN_DEPTH -DHAVE_G_LISTENV -DHAVE_RB_CHECK_ARRAY_TYPE -DHAVE_RB_CHECK_HASH_TYPE -DHAVE_RB_EXEC_RECURSIVE -DHAVE_RB_ERRINFO -DHAVE_RB_THREAD_CALL_WITHOUT_GVL -DHAVE_RUBY_NATIVE_THREAD_P -DHAVE_RB_THREAD_CALL_WITH_GVL -DHAVE_RB_GC_REGISTER_MARK_OBJECT -DHAVE_RB_EXC_NEW_STR -DHAVE_RB_ENC_STR_NEW_STATIC -DRUBY_GLIB2_COMPILATION -Wdate-time -D_FORTIFY_SOURCE=2   -fPIC -g -O2 -ffile-prefix-map=BUILDDIR=. -fstack-protector-strong -Wformat -Werror=format-security -fPIC -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Waggregate-return -Wcast-align -Wformat=2 -Winit-self -Wlarger-than-65500 -Wmissing-declarations -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpacked -Wp,-D_FORTIFY_SOURCE=2 -Wpointer-arith -Wundef -Wunsafe-loop-optimizations -Wwrite-strings  -pthread  -o rbglib_bookmarkfile.o -c rbglib_bookmarkfile.c
> rbglib_bookmarkfile.c:39:1: error: static declaration of ‘g_bookmark_file_get_type’ follows non-static declaration
>    39 | g_bookmark_file_get_type(void)
>       | ^~~~~~~~~~~~~~~~~~~~~~~~
> In file included from /usr/include/glib-2.0/gobject/gboxed.h:29,
>                  from /usr/include/glib-2.0/gobject/gobject.h:31,
>                  from /usr/include/glib-2.0/gobject/gbinding.h:31,
>                  from /usr/include/glib-2.0/glib-object.h:24,
>                  from rbgobject.h:25,
>                  from rbgprivate.h:31,
>                  from rbglib_bookmarkfile.c:22:
> /usr/include/glib-2.0/gobject/glib-types.h:402:9: note: previous declaration of ‘g_bookmark_file_get_type’ with type ‘GType(void)’ {aka ‘long unsigned int(void)’}
>   402 | GType   g_bookmark_file_get_type   (void) G_GNUC_CONST;
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~
> rbglib_bookmarkfile.c:50: warning: "G_TYPE_BOOKMARK_FILE" redefined
>    50 | #define G_TYPE_BOOKMARK_FILE (g_bookmark_file_get_type())
>       | 
> /usr/include/glib-2.0/gobject/glib-types.h:337: note: this is the location of the previous definition
>   337 | #define G_TYPE_BOOKMARK_FILE (g_bookmark_file_get_type ())
>       | 
> rbglib_bookmarkfile.c: In function ‘rg_set_groups’:
> rbglib_bookmarkfile.c:388:47: warning: passing argument 3 of ‘g_bookmark_file_set_groups’ from incompatible pointer type [-Wincompatible-pointer-types]
>   388 |     g_bookmark_file_set_groups(bookmark, uri, groups, n);
>       |                                               ^~~~~~
>       |                                               |
>       |                                               gchar ** {aka char **}
> In file included from /usr/include/glib-2.0/glib.h:39,
>                  from /usr/include/glib-2.0/gobject/gbinding.h:30:
> /usr/include/glib-2.0/glib/gbookmarkfile.h:140:69: note: expected ‘const gchar **’ {aka ‘const char **’} but argument is of type ‘gchar **’ {aka ‘char **’}
>   140 |                                                     const gchar   **groups,
>       |                                                     ~~~~~~~~~~~~~~~~^~~~~~
> make[1]: *** [Makefile:246: rbglib_bookmarkfile.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2023/07/26/ruby-gnome_3.4.3-2_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20230726;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20230726&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.