<html><head></head><body>Sadly this patch cannot be applied to node-terser without regression<br><br><div class="gmail_quote">Le 28 août 2022 19:29:33 GMT+02:00, Mohd Bilal <mdbilal@disroot.org> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre dir="auto" class="k9mail">Hi Yadd :)<br><br>On Thu, 25 Aug 2022 10:58:21 +0200 Yadd <yadd@debian.org> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">ruby-terser uses a patched terser.js (see <a href="https://github.com/ahorek/terser-ruby/blob/master/patches/terser-sync.patch)">https://github.com/ahorek/terser-ruby/blob/master/patches/terser-sync.patch)</a><br><br>So this issue is simple to fix: copy node-terser files into vendor/terser and patch it using upstream patch.<br></blockquote><br><br>I had a look at this and tried doing what you suggested, but copying and patching had zero effect on the tests. They are still failing.<br><br>According to [1] I think terser bin has to be generated from the source with the patches applied.<br><br>I tried your approach and tried generating the minfied terser.js but the autopkgtest error[2] suggests that the patched function(minifySync) aren't seen in the minified lib/terser.js<br><br>Can you maybe use this upstream patch onto node-terser and also generate a min file that can be used with ruby-terser? Is it possible?<br><br>Or do you have any other alternative to suggest ?<br><br>[1] - <a href="https://github.com/ahorek/terser-ruby/blob/master/Rakefile#L55">https://github.com/ahorek/terser-ruby/blob/master/Rakefile#L55</a>#L66<br>[2] - <a href="http://paste.debian.net/1251967/">http://paste.debian.net/1251967/</a><br><br>Thanks<br><div class="k9mail-signature">-- <br>╭───────────────────────────────────────────────────╮<br>│ Mohammed Bilal │<br>│ 2D65 BC1E B966 5A6E 97F9 730A B3F5 9452 8521 9E1F │<br>╰───────────────────────────────────────────────────╯<br></div></pre></blockquote></div><div style='white-space: pre-wrap'><div class='k9mail-signature'>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</div></div></body></html>