<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 19/11/2023 12:14, Peter Michael
Green wrote:<br>
</div>
<blockquote type="cite"
cite="mid:31adf20d-fd25-08b7-b960-2e07ff920c20@debian.org">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<p>Package: rust-ripasso-cursive<br>
Version: 0.6.1-1<br>
Severity: serious<br>
Tags: trixie, sid<br>
<br>
It appears, that despite the version number indicating a
compatible release, that the new<br>
version of ripasso broke the build of ripasso-cursive.<br>
<br>
<a class="moz-txt-link-freetext"
href="https://tests.reproducible-builds.org/debian/rb-pkg/trixie/amd64/rust-ripasso-cursive.html"
moz-do-not-send="true">https://tests.reproducible-builds.org/debian/rb-pkg/trixie/amd64/rust-ripasso-cursive.html</a><br>
<br>
</p>
<blockquote type="cite">
<pre>error[E0425]: cannot find function `push` in module `pass`
--> src/main.rs:941:29
|
941 | let push_result = pass::push(&store.lock().unwrap().lock().unwrap());
| ^^^^ not found in `pass`
|
help: consider importing this function
|
18 + use ripasso::git::push;
|
help: if you import `push`, refer to it directly
|
941 - let push_result = pass::push(&store.lock().unwrap().lock().unwrap());
941 + let push_result = push(&store.lock().unwrap().lock().unwrap());
|
error[E0425]: cannot find function `pull` in module `pass`
--> src/main.rs:953:19
|
953 | let _ = pass::pull(&store.lock().unwrap().lock().unwrap())
| ^^^^ not found in `pass`
|
help: consider importing this function
|
18 + use ripasso::git::pull;
|
help: if you import `pull`, refer to it directly
|
953 - let _ = pass::pull(&store.lock().unwrap().lock().unwrap())
953 + let _ = pull(&store.lock().unwrap().lock().unwrap())
|
error[E0603]: function `init_git_repo` is private
--> src/wizard.rs:32:26
|
32 | let init_res = pass::init_git_repo(&pass::password_dir(password_store_dir, home).unwrap());
| ^^^^^^^^^^^^^ private function
|
note: the function `init_git_repo` is defined here
--> /usr/share/cargo/registry/ripasso-0.6.4/src/pass.rs:34:60
|
34 | add_and_commit_internal, commit, find_last_commit, init_git_repo, match_with_parent,
| ^^^^^^^^^^^^^
</pre>
</blockquote>
<br>
I tried to update ripasso-cursive to 0.6.4 to match ripasso but I
got.<br>
<blockquote type="cite">Applying patch
unbreak-new-user-wizard.patch<br>
patching file src/main.rs<br>
Hunk #1 succeeded at 1111 with fuzz 1 (offset -58 lines).<br>
Hunk #2 FAILED at 1189.<br>
Hunk #3 succeeded at 1324 with fuzz 1 (offset 109 lines).<br>
Hunk #4 FAILED at 1773.<br>
Hunk #5 FAILED at 1789.<br>
Hunk #6 FAILED at 1798.<br>
Hunk #7 succeeded at 1849 with fuzz 2 (offset 43 lines).<br>
4 out of 7 hunks FAILED -- rejects in file src/main.rs<br>
Patch unbreak-new-user-wizard.patch does not apply (enforce with
-f)</blockquote>
<p>Can someone confirm whether this patch is still needed, and
if-so<br>
update it for the new upstream version?<br>
</p>
</blockquote>
<p>For what it's worth I was able to get a succesful build by.</p>
<p>1. Upgrading ripasso-cursive to 0.6.3 (0.6.4 has a new dependency
that is not in Debian)<br>
2. Disabling unbreak-new-user-wizard.patch andÂ
translation-locations.patch<br>
<br>
I would still like feedback from Alexander on whether those
patches are still<br>
relavent.<br>
</p>
</body>
</html>