[From nobody Fri Oct  2 12:37:06 2026
Received: (at submit) by bugs.debian.org; 27 Aug 2026 14:19:27 +0000
X-Spam-Checker-Version: SpamAssassin 4.0.1-bugs.debian.org_2005_01_02
 (2024-03-25) on buxtehude.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.3 required=4.0 tests=BAYES_00,
 BODY_INCLUDES_PACKAGE,FROMDEVELOPER,HAS_PACKAGE,SPF_HELO_NONE,
 SPF_SOFTFAIL autolearn=ham autolearn_force=no
 version=4.0.1-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 26; hammy, 146; neutral, 58; spammy,
 0. spammytokens: hammytokens:0.000-+--H*r:sk:plugwas,
 0.000-+--H*F:U*plugwash, 0.000-+--H*rp:U*plugwash,
 0.000-+--Hx-spam-relays-external:sk:plugwas, 0.000-+--H*RU:sk:plugwas
Return-path: <plugwash@debian.org>
Received: from mythic.p10link.net ([93.93.134.24]:53018)
 by buxtehude.debian.org with esmtps
 (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
 (Exim 4.96) (envelope-from <plugwash@debian.org>) id 1wzaww-00Bzfi-2c
 for submit@bugs.debian.org; Thu, 27 Aug 2026 14:19:26 +0000
Received: from [10.0.0.105] (unknown [79.142.128.251])
 by mythic.p10link.net (Postfix) with ESMTPSA id 8CD54A4A
 for <submit@bugs.debian.org>; Thu, 27 Aug 2026 14:19:23 +0000 (UTC)
Message-ID: <cb14e5c3-432c-4947-af92-3eddf882e4ff@debian.org>
Date: Thu, 27 Aug 2026 15:19:23 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: submit@bugs.debian.org
From: Peter Michael Green <plugwash@debian.org>
Subject: rust-sequoia-keystore-openpgp-card - needs update for openpgp-card 0.7
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Delivered-To: submit@bugs.debian.org

Package: rust-sequoia-keystore-openpgp-card
Version: 0.2.1-1
x-debbugs-cc: tsimonq2@debian.org
Severity: serious

Simon recently updated the rust-openpgp-card package
to 0.7 (I had planned to update it, but only to version 0.6).

I was able to make a patch that builds and runs tests
succesfully, but I am not happy uploading it without review
from someone more familiar with the code, and ideally
someone who actually uses openpgp cards.

The patch addresses the following issues.

The signature of the "signature_for_hash" and
"authenticate_for_hash" method has changed, previously
they took a paramer of type "Hash", while now they take
two parameters of type "SigningAlgo" and "&[u8]", I've
tried to translate things as best I can but there seem to
be some differences, for example the old "Hash" type
had different variants for ECDSA and EdDSA while the
new "SigningAlgo" type just has a single variant for ECC

The to_admin_card function has been renamed to
as_admin_card

Many parameters and return values have changed from Box
or Vec to references. This required me to restructure the SqEccKey
type to perform private key conversion in SqEccKey::new
rather than in the implementation of the EccKey trait. It also
raises some potential questions about cleanup of private
data before freeing memory, I don't know what sequoia's
policy is on that.

I have brought this up upstream at
]