[Pkg-salt-team] Uploaded repository - some issues remain

[Franklin G. Mendoza]

Hi,

2013/4/7 Joe Healy <joehealy at gmail.com>:
> On Sun, Apr 7, 2013 at 3:56 PM, Joe Healy <joehealy at gmail.com> wrote:
>> I've checked this and it will fail once upstream do their next release
>> (They've already removed the file).
>
>
> After more testing, I've made some additional minor changes -
> putting the .DS_Store back in the repo as it should be removed
> via debian/rules rather than in the git repo.
>
> I've also now uploaded the changes.
>
> I think the next steps are:
>
> 1) Further testing
>
> I've installed/uninstalled the packages, looked at debdiff. It is
> probably worth testing on someone elses system.
>
> To do so:
>
> git-dch

I do a "git-dch -a" and this add a new revision (0.14.0-2), Joe shows
as he did the last change (this is correct), add this commit "Updated
default branch for git-buildpackage" and show joe's name and my name
on [].

> git-buildpackage -us -uc --git-ignore-new
>
> If you do the above, you will get lintian warnings about
> changelog lines being too long.

W: salt source: changelog-should-mention-nmu
This is solved adding your name (Joe) and email in the maintainer
field, until we formalize the team on Debian this will be a little
problem.

W: salt source: source-nmu-has-incorrect-version-number 0.14.0-2

This is because it is not the lastes original maintainer and should be
addeded a sub-revision number something like 0.14.0-1.1

Common warnings on this packages process:

W: salt-doc: macos-ds-store-file-in-package
usr/share/doc/salt/html/_static/fonts/.DS_Store.gz
W: salt-common: manpage-has-errors-from-man
usr/share/man/man7/salt.7.gz 2052: warning [p 22, 4.3i, div `3tbd2,2',
0.0i]: can't break line

>
> 2) Changelog
>
> Should the distribution field be unstable?
>
> If I do a git-dch, I get lots of detail (every change). Is this
> too much detail?
>
> Is there anything else that should go in?
>
> 3) Sponsor Review
>
> 4) Sponsor upload.
>
> Is this correct?
>
> Thanks,
>
> Joe

Cheers,

Franklin
>
> _______________________________________________
> pkg-salt-team mailing list
> pkg-salt-team at lists.alioth.debian.org
> https://lists.alioth.debian.org/mailman/listinfo/pkg-salt-team