[Pkg-samba-maint] [samba] 130/135: s3:winbindd fix use of uninitialized variables

Ivo De Decker ivodd at moszumanska.debian.org
Sat Jan 11 21:30:32 UTC 2014


This is an automated email from the git hooks/post-receive script.

ivodd pushed a commit to branch master
in repository samba.

commit c765c2ac7687be26eae7376861ee9da500744942
Author: Christian Ambach <ambi at samba.org>
Date:   Mon Sep 16 13:18:17 2013 +0200

    s3:winbindd fix use of uninitialized variables
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=10280
    
    Signed-off-by: Christian Ambach <ambi at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    (cherry picked from commit 7393781a57891687b464762b0954e6c936f750bb)
    
    Autobuild-User(v4-1-test): Karolin Seeger <kseeger at samba.org>
    Autobuild-Date(v4-1-test): Thu Jan  2 21:49:28 CET 2014 on sn-devel-104
---
 source3/winbindd/winbindd_cache.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/source3/winbindd/winbindd_cache.c b/source3/winbindd/winbindd_cache.c
index fe05759..ec7ddb7 100644
--- a/source3/winbindd/winbindd_cache.c
+++ b/source3/winbindd/winbindd_cache.c
@@ -2124,6 +2124,19 @@ static NTSTATUS rids_to_names(struct winbindd_domain *domain,
 			old_status) {
 			have_mapped = have_unmapped = false;
 
+			*names = talloc_array(mem_ctx, char *, num_rids);
+			if (*names != NULL) {
+				result = NT_STATUS_NO_MEMORY;
+				goto error;
+			}
+
+			*types = talloc_array(mem_ctx, enum lsa_SidType,
+					      num_rids);
+			if (*types != NULL) {
+				result = NT_STATUS_NO_MEMORY;
+				goto error;
+			}
+
 			for (i=0; i<num_rids; i++) {
 				struct dom_sid sid;
 				struct cache_entry *centry;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-samba/samba.git




More information about the Pkg-samba-maint mailing list