[Pkg-samba-maint] python3-matplotlib dependency, where is it used?

[Andreas Hasenack]

Hi Mathieu,

On Tue, Dec 3, 2019 at 5:06 PM Mathieu Parent <math.parent at gmail.com> wrote:
>
> Le mar. 3 déc. 2019 à 17:31, Andreas Hasenack <andreas at canonical.com> a écrit :
> >
> > Hi,
> >
> > I'm updating the samba packages in Ubuntu and saw these new
> > dependencies in the Debian package:
> >
> > samba (2:4.11.1+dfsg-3) unstable; urgency=medium
> >
> >   * Add some python dependencies:
> >     - python3-matplotlib : samba-tool visualize
> >     - python3-markdown   : samba-tool domain schemaupgrade
> >     - python3-dnspython  : samba-tool dns
> >
> > In Ubuntu, python3-matplotlib (src:matplotlib) is in Universe, so it
> > can't be a Recommends. I ran a grep on the source code, and the only
> > place where I found this module being imported is in
> > script/attr_count_read. I don't see this script being installed with
> > any samba package, though. The only reference I found to it was in
> > ./source4/dsdb/samdb/ldb_modules/count_attrs.c, but as a comment, it's
> > not even being called.
> >
> > In any case, I proposed this upstream:
> > https://gitlab.com/samba-team/samba/merge_requests/958 and my plan is
> > to add it as a suggests, or maybe even remove it, since I couldn't
> > find any place where it is used.
> >
> > Did I miss something or is python3-matplotlib not necessary?
>
> We can probably drop this dep entirely.

Thanks for the reply. I created
https://salsa.debian.org/samba-team/samba/merge_requests/42 with this
change.