[Pkg-samba-maint] [Git][samba-team/samba][experimental] 44 commits: VERSION: Bump version up to Samba 4.19.0rc2...

Michael Tokarev (@mjt) gitlab at salsa.debian.org
Tue Aug 8 09:11:43 BST 2023



Michael Tokarev pushed to branch experimental at Debian Samba Team / samba


Commits:
3bab56a7 by Jule Anger at 2023-07-28T14:11:30+02:00
VERSION: Bump version up to Samba 4.19.0rc2...

and re-enable GIT_SNAPSHOT.

Signed-off-by: Jule Anger <janger at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>

- - - - -
b4f10979 by Arvid Requate at 2023-08-01T11:11:16+00:00
For Bug #9959: local talloc frame for next commit

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9959

Signed-off-by: Arvid Requate <requate at univention.de>

[abartlet at samba.org Added additional talloc_free() in failure paths]
Reviewed-by: Stefan Metzmacher <metze at samba.org>

(cherry picked from commit b6e80733c3a589f9d784eec86fc713f1ec9c1049)

- - - - -
e5ea3562 by Arvid Requate at 2023-08-01T11:11:16+00:00
Bug #9959: Don't search for CN=System

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9959

Signed-off-by: Arvid Requate <requate at univention.de>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 2d461844a201fbca55ebc9a46a15e1d16048055b)

- - - - -
37094ba8 by Andrew Bartlett at 2023-08-01T11:11:16+00:00
dsdb: Add new function samdb_system_container_dn()

This will replace many calls crafting or searching for this DN
elsewhere in the code.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9959

Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>

Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 25b0e1102e1a502152d2695aeddf7c65555b16fb)

- - - - -
3493671c by Andrew Bartlett at 2023-08-01T11:11:16+00:00
dsdb: Use samdb_system_container_dn() in samldb.c

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9959

Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 97b682e0eb0450513dcecb74be672e18e84fe7a2)

- - - - -
66605c7c by Andrew Bartlett at 2023-08-01T11:11:16+00:00
dsdb: Use samdb_get_system_container_dn() to get Password Settings Container

By doing this we use the common samdb_get_system_container_dn() routine and we
avoid doing a linerize and parse step on the main DN, instead using the
already stored parse of the DN.  This is more hygenic.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9959

Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 3669caa97f76d3e893ac6a1ab88341057929ee6a)

- - - - -
9cb4754d by Andrew Bartlett at 2023-08-01T11:11:16+00:00
s4-rpc_server/lsa: Use samdb_system_container_dn() in dcesrv_lsa_get_policy_state()

This is now exactly the same actions, but just uses common code to do it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9959

Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 4e18066fa243da1c505f782ba87187c3bb1078ee)

- - - - -
2f1502a7 by Andrew Bartlett at 2023-08-01T11:11:16+00:00
s4-rpc_server/netlogon: Use samdb_system_container_dn() in fill_trusted_domains_array()

This is now exactly the same actions, but just uses common code to do it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9959

Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit a900f6aa5d909d912ee3ca529baa4047c9c4da87)

- - - - -
4f1156f1 by Andrew Bartlett at 2023-08-01T11:11:16+00:00
s4-rpc_server/backupkey: Use samdb_system_container_dn() in set_lsa_secret()

This is now exactly the same actions, but just uses common code to do it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9959

Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 13eed1e0e7d0bdef6b5cdb6b858f124b812adbea)

- - - - -
4cd7ead4 by Andrew Bartlett at 2023-08-01T11:11:16+00:00
s4-rpc_server/backupkey: Use samdb_system_container_dn() in get_lsa_secret()

This is now exactly the same actions, but just uses common code to do it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9959

Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 9b4f3f3cb4ed17bb233d3b5ccd191be63f01f3f4)

- - - - -
bffe1f57 by Andrew Bartlett at 2023-08-01T11:11:16+00:00
dsdb: Use samdb_system_container_dn() in dsdb_trust_*()

This is now exactly the same actions, but just uses common code to do it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9959

Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 4250d07e4dcd43bf7450b1ae603ff46fdc892d02)

- - - - -
68db9b73 by Andrew Bartlett at 2023-08-01T12:12:30+00:00
dsdb: Use samdb_system_container_dn() in pdb_samba_dsdb_*()

This makes more calls to add children, but avoids the cn=system string in the
codebase which makes it easier to audit that this is always being built
correctly.

Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>

Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Mon Jul 31 07:20:21 UTC 2023 on atb-devel-224

(cherry picked from commit 5571ce9619d856d3c9545099366f4e0259aee8ef)

RN: A second container with name CN=System would disable the operation
 of the Samba AD DC.  Samba now finds the CN=System container by exact
 DN and not a search.

Autobuild-User(v4-19-test): Jule Anger <janger at samba.org>
Autobuild-Date(v4-19-test): Tue Aug  1 12:12:30 UTC 2023 on atb-devel-224

- - - - -
e7f91e1d by Jones Syue at 2023-08-03T09:45:34+00:00
vfs_aio_pthread: fix segfault if samba-tool ntacl get

If configured as AD DC and aio_pthread appended into 'vfs objects'[1],
run these commands would get segfault:
1. sudo samba-tool ntacl get .
2. sudo net vfs getntacl sysvol .
gdb said it goes through aio_pthread_openat_fn() @ vfs_aio_pthread.c[2],
and the fsp->conn->sconn->client is null (0x0).

'sconn->client' memory is allocated when a new connection is accpeted:
smbd_accept_connection > smbd_process > smbXsrv_client_create
While running local commands looks like it would not go through
smbXsrv_client_create so the 'client' is null, segfault might happen.
We should not dereference 'client->server_multi_channel_enabled',
if 'client' is null.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15441

[1] smb.conf example, samba-4.18.5, ubuntu 22.04.2
[global]
        dns forwarder = 127.0.0.53
        netbios name = U22-JONES-88X1
        realm = U22-JONES-88X1.X88X1.JONES
        server role = active directory domain controller
        workgroup = X88X1
        idmap_ldb:use rfc2307 = yes
        vfs objects = dfs_samba4 acl_xattr aio_pthread

[sysvol]
        path = /var/lib/samba/sysvol
        read only = No

[netlogon]
        path = /var/lib/samba/sysvol/u22-jones-88x1.x88x1.jones/scripts
        read only = No

[2] gdb
(gdb) run /usr/local/samba/bin/samba-tool ntacl get .
Starting program: /usr/local/Python3/bin/python3 /usr/local/samba/bin/samba-tool ntacl get .
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault.
0x00007fffd0eb809e in aio_pthread_openat_fn (handle=0x8d5cc0, dirfsp=0x8c3070, smb_fname=0x18ab4f0, fsp=0x1af3550, flags=196608, mode=0)
    at ../../source3/modules/vfs_aio_pthread.c:467
warning: Source file is more recent than executable.
467             if (fsp->conn->sconn->client->server_multi_channel_enabled) {
(gdb) bt
    at ../../source3/modules/vfs_aio_pthread.c:467
    at ../../source3/smbd/pysmbd.c:320
---Type <return> to continue, or q <return> to quit---
(gdb) f
    at ../../source3/modules/vfs_aio_pthread.c:467
467             if (fsp->conn->sconn->client->server_multi_channel_enabled) {
(gdb) p fsp->conn->sconn->client
$1 = (struct smbXsrv_client *) 0x0
(gdb)

Signed-off-by: Jones Syue <jonessyue at qnap.com>
Reviewed-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
(cherry picked from commit 8f4c1c67b4f118a9a47b09ac7908cd3d969b19c2)

Autobuild-User(v4-19-test): Jule Anger <janger at samba.org>
Autobuild-Date(v4-19-test): Thu Aug  3 09:45:34 UTC 2023 on atb-devel-224

- - - - -
d5939205 by Noel Power at 2023-08-03T13:37:10+00:00
selftest: Add new dfs share (with widelinks enabled)

Adds share (to be used in later test) that has dfs node
but additionally has widelinks set to yes

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15435

Signed-off-by: Noel Power <noel.power at suse.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
(cherry picked from commit b57cdfd7efb161cf96b3a39dc7a1652db817e602)

- - - - -
ece48278 by Noel Power at 2023-08-03T13:37:10+00:00
sefltest: Add new regression test dfs with widelinks = yes

Adds a new test trying to cd into dfs path on share with
widelinks enabled, should generate an error (see BUG:)

Add a knownfail so CI continues

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15435

Signed-off-by: Noel Power <noel.power at suse.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
(cherry picked from commit 3d2e9db8b95f9f45d486f8272e53584975f177fa)

- - - - -
368b3e61 by Noel Power at 2023-08-03T13:37:10+00:00
s3/modules: Add flag indicating if connected share is a dfs share

Not used yet, will be used in the next commit to avoid testing
if the connected share is a dfs one.

Pair-Programmed-With: Jeremy Alison <jra at samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15435

Signed-off-by: Noel Power <noel.power at suse.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
(cherry picked from commit 2668dcd0968133cca4f8410bf8c41ed0483f5d87)

- - - - -
1231268c by Noel Power at 2023-08-03T14:30:32+00:00
s3/modules: Fix DFS links when widelinks = yes

In openat(), even if we fail to open the file,
propagate stat if and only if the object is a link in
a DFS share. This allows calling code to further process
the link.

Also remove knownfail

Pair-Programmed-With: Jeremy Alison <jra at samba.org>

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15435

Signed-off-by: Noel Power <noel.power at suse.com>
Reviewed-by: Jeremy Allison <jra at samba.org>

Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Jul 29 00:43:52 UTC 2023 on atb-devel-224

(cherry picked from commit 0bf8b25aacdf2f5c746922320b32e3f0886c81f5)

Autobuild-User(v4-19-test): Jule Anger <janger at samba.org>
Autobuild-Date(v4-19-test): Thu Aug  3 14:30:32 UTC 2023 on atb-devel-224

- - - - -
9a87e206 by Joseph Sutton at 2023-08-04T09:31:54+00:00
third_party/heimdal: Import lorikeet-heimdal-202308030152 (commit 2a036a6fd80833799316b8a85623cdea3a1135df)

This import fixes the build on 32-bit FreeBSD.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15443

Signed-off-by: Joseph Sutton <josephsutton at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Autobuild-User(master): Joseph Sutton <jsutton at samba.org>
Autobuild-Date(master): Thu Aug  3 05:40:28 UTC 2023 on atb-devel-224

(cherry picked from commit 06d673a1a0c54e78773cc951124486b547ca880d)

Autobuild-User(v4-19-test): Jule Anger <janger at samba.org>
Autobuild-Date(v4-19-test): Fri Aug  4 09:31:54 UTC 2023 on atb-devel-224

- - - - -
03df070c by Michael Tokarev at 2023-08-04T17:26:56+03:00
d/rules: wrap _PYTHON_SYSCONFIGDATA_NAME setting to cross-compile case

On e.g. buster, _PYTHON_SYSCONFIGDATA_NAME is different, so this assignment
does not work right.  In order for it to work on buster, add condition on
host vs build gnu type. This breaks compilation with foreign python binary.

- - - - -
7de94122 by Michael Tokarev at 2023-08-04T17:28:40+03:00
d/control: fix description of samba-common-bin (samba-client)

- - - - -
594f6c07 by Michael Tokarev at 2023-08-04T17:29:09+03:00
update changelog; upload version 4.18.5+dfsg-2 to unstable

- - - - -
19e9735c by Jule Anger at 2023-08-08T09:11:57+02:00
WHATSNEW: Add release notes for Samba 4.19.0rc2.

Signed-off-by: Jule Anger <janger at samba.org>

- - - - -
e7330e36 by Jule Anger at 2023-08-08T09:12:57+02:00
VERSION: Disable GIT_SNAPSHOT for the 4.19.0rc2 release.

Signed-off-by: Jule Anger <janger at samba.org>

- - - - -
c47acece by Michael Tokarev at 2023-08-08T10:44:31+03:00
d/gbp.conf, d/README.source.md: prepare for 4.19 experimental

- - - - -
5f8bbf1f by Michael Tokarev at 2023-08-08T10:46:00+03:00
d/changelog: start 4.19 series

- - - - -
6956ea2f by Michael Tokarev at 2023-08-08T10:47:57+03:00
New upstream version 4.19.0~rc2+dfsg
- - - - -
093a61aa by Michael Tokarev at 2023-08-08T10:48:36+03:00
Update upstream source from tag 'upstream/4.19.0_rc2+dfsg'

Update to upstream version '4.19.0~rc2+dfsg'
with Debian dir beb7af3af2b31ec98fcba8386dd678786c0054c8
- - - - -
f5cf6aed by Michael Tokarev at 2023-08-08T10:49:19+03:00
d/patches: remove patches applied upstream

 heimdal-to-support-KEYRING-ccache.patch
 spelling.patch

- - - - -
c13ba397 by Michael Tokarev at 2023-08-08T10:49:19+03:00
refresh patches

meaningful-error-if-no-python3-markdown.patch
meaningful-error-if-no-samba-ad-provision.patch

- - - - -
ada2aba2 by Michael Tokarev at 2023-08-08T10:49:19+03:00
d/control: update talloc/tevent/tdb build-deps

- - - - -
953634ef by Michael Tokarev at 2023-08-08T10:49:19+03:00
d/smbclient.install: remove smbgetrc.5

- - - - -
953b8c55 by Michael Tokarev at 2023-08-08T10:49:39+03:00
d/patches: add ldb 2.7.1 & 2.7.2 ABI files

ldb-2.7.2 contains a few actual new symbols, it is not just a version
bump. Get ldb-2.7.2.sigs from ldb-2.7.2 tag.

- - - - -
f71d45a0 by Michael Tokarev at 2023-08-08T10:49:39+03:00
d/libldb2.symbols: add new symbols (ldb_val_as_*) and new version (2.8.0)

- - - - -
d576af5b by Michael Tokarev at 2023-08-08T10:49:39+03:00
d/python3-ldb.symbols: remove unused versions, add new version

- - - - -
787fe361 by Michael Tokarev at 2023-08-08T10:50:12+03:00
d/samba-common-bin.install: install samba-log-parser (for winbindd for now)

- - - - -
3c37c139 by Michael Tokarev at 2023-08-08T10:50:12+03:00
d/samba-libs.install: 2 new libs

- - - - -
e0926eb7 by Michael Tokarev at 2023-08-08T10:50:12+03:00
d/samba-libs.install, d/samba-testsuite.install: move libshares-samba4.so.0 from samba-libs to samba-testsuite

- - - - -
dfb5aa83 by Michael Tokarev at 2023-08-08T10:50:12+03:00
d/samba-libs.install, d/samba-vfs-modules.install: move libdfs-server-ad-samba4.so.0 from samba-libs to samba-vfs-modules

- - - - -
e901db68 by Michael Tokarev at 2023-08-08T10:50:12+03:00
d/samba-libs.install, d/samba-common-bin.install: move libnet-keytab-samba4.so.0 from samba-libs to samba-common-bin (used by net only)

- - - - -
358c8af7 by Michael Tokarev at 2023-08-08T10:51:41+03:00
d/samba-libs.install, d/samba-common-bin.install: move libRPC-WORKER-samba4.so.0 from samba-libs to samba-common-bin (used by usr/libexec/samba/rpcd_*)

- - - - -
6dbdb25f by Michael Tokarev at 2023-08-08T10:51:41+03:00
d/source/lintian-overrides: remove unused source-is-missing override

- - - - -
fe0ce490 by Michael Tokarev at 2023-08-08T10:51:41+03:00
d/samba-vfs-modules.lintian-overrides: remove unused spelling-error-in-binary override

- - - - -
41075cca by Michael Tokarev at 2023-08-08T10:51:41+03:00
d/control: add Breaks/Replaces for moved libraries

- - - - -
96ca4f77 by Michael Tokarev at 2023-08-08T10:57:57+03:00
update changelog; upload version 4.19.0~rc2+dfsg-1 to experimental

- - - - -


30 changed files:

- VERSION
- WHATSNEW.txt
- + debian/.gitignore
- + debian/README.Debian
- + debian/README.source
- + debian/README.source.md
- + debian/TODO
- + debian/addshare.py
- + debian/changelog
- + debian/clean
- + debian/control
- + debian/copyright
- + debian/ctdb.NEWS
- + debian/ctdb.README.hurd
- + debian/ctdb.README.kfreebsd
- + debian/ctdb.dirs
- + debian/ctdb.docs
- + debian/ctdb.example/nfs-kernel-server/98-nfs-static-ports.conf
- + debian/ctdb.example/nfs-kernel-server/enable-nfs.sh
- + debian/ctdb.example/nfs-kernel-server/nfs.conf
- + debian/ctdb.example/nfs-kernel-server/quota
- + debian/ctdb.example/nfs-kernel-server/services
- + debian/ctdb.examples
- + debian/ctdb.install
- + debian/ctdb.logrotate
- + debian/ctdb.postinst
- + debian/ctdb.postrm
- + debian/dirs
- + debian/gbp.conf
- + debian/gdbcommands


The diff was not included because it is too large.


View it on GitLab: https://salsa.debian.org/samba-team/samba/-/compare/eda0f93e3b14ef71f7dfa971548ebbe2d2411ddf...96ca4f77158f48648f3628d8ce4f0d10ace5f0aa

-- 
View it on GitLab: https://salsa.debian.org/samba-team/samba/-/compare/eda0f93e3b14ef71f7dfa971548ebbe2d2411ddf...96ca4f77158f48648f3628d8ce4f0d10ace5f0aa
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-samba-maint/attachments/20230808/9ab6e76a/attachment-0001.htm>


More information about the Pkg-samba-maint mailing list